Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | NXglyph.c: check for malloc error | Ulrich Sibiller | 2021-01-15 | 1 | -0/+7 | |
| | | | | | "V575 The potential null pointer is passed into 'memcpy' function. Inspect the first argument." | |||||
* | Keyboard.c: fix possible NULL pointer dereference | Ulrich Sibiller | 2021-01-15 | 1 | -0/+5 | |
| | | | | | found by PVS Studio: "V522 There might be dereferencing of a potential null pointer 'keymap'." | |||||
* | Drawable.c: Prevent PVS Studio warning | Ulrich Sibiller | 2021-01-15 | 1 | -1/+3 | |
| | | | | | "V560 A part of conditional expression is always true: oldStatus == NotSynchronized." | |||||
* | Display.c: prevent PVS Studio realloc warning | Ulrich Sibiller | 2021-01-15 | 1 | -5/+11 | |
| | | | | | | "V701 realloc() possible leak: when realloc() fails in allocating memory, original pointer 'nxagentDefaultColormaps' is lost. Consider assigning realloc() to a temporary pointer." | |||||
* | Atoms.c: add explanation for PVS Studio warning | Ulrich Sibiller | 2021-01-15 | 1 | -0/+3 | |
| | | | | | "V575 The potential null pointer is passed into 'strlen' function. Inspect the first argument. Check lines: 420, 403." | |||||
* | NXpicture.c: remove unneccessary check | Ulrich Sibiller | 2021-01-15 | 1 | -15/+12 | |
| | | | | | | | Code can only be reached if pPicture is non-NULL. Besides, pPicture will be accessed later anyway, regardless of this check. Finding of PVS Studio: "V547 Expression 'pPicture != NULL' is always true." | |||||
* | Keyboard.c: simplify code | Ulrich Sibiller | 2021-01-15 | 1 | -5/+3 | |
| | | | | Based on PVS Studio finding: "V547 Expression 'data' is always true." | |||||
* | Colormap.c: remove unneccessary check | Ulrich Sibiller | 2021-01-15 | 1 | -1/+1 | |
| | | | | | | | | success would always be true at the beginning of the loop as it is part of the loop condition. Finding from PVS Studio: "V560 A part of conditional expression is always true: success." | |||||
* | Colormap.c: fix parentheses | Ulrich Sibiller | 2021-01-15 | 1 | -1/+1 | |
| | | | | | | PVS Studio: "V592 The expression was enclosed by parentheses twice: '((* pRed * (limg + 1)))'. One pair of parentheses is unnecessary or misprint is present." | |||||
* | Atoms.c: silence PVS Studio warning | Ulrich Sibiller | 2021-01-15 | 1 | -2/+6 | |
| | | | | | | "V701 realloc() possible leak: when realloc() fails in allocating memory, original pointer 'privAtomMap' is lost. Consider assigning realloc() to a temporary pointer." | |||||
* | Atoms.c: cosmetics in nxagentWriteAtom() | Ulrich Sibiller | 2021-01-15 | 1 | -1/+2 | |
| | ||||||
* | Atoms.c: fix strlen(NULL) | Ulrich Sibiller | 2021-01-15 | 1 | -1/+1 | |
| | | | | | FIX PVS Studio finding "V575 The potential null pointer is passed into 'strlen' function. Inspect the first argument" | |||||
* | nxagent: make full screen mode selectable at startup | Ulrich Sibiller | 2021-01-15 | 4 | -9/+33 | |
| | | | | | | | | fullscreen= now accepts the new value "2" for a fullscreen covering only one screen. -geometry and geometry= now know additional keywords "allscreens" and "onescreen". Fixes ArcticaProject/nx-libs#923 | |||||
* | Revert "CVE-2020-14360: Check SetMap request length carefully." | Mike Gabriel | 2021-01-15 | 1 | -91/+0 | |
| | | | | This reverts commit 4eba4f53ad8c62c27c12835e58184d66121ff636. | |||||
* | nxagent: nxagent(Default)WindowIsVisible() are Booleans | Ulrich Sibiller | 2021-01-15 | 4 | -7/+7 | |
| | ||||||
* | Keyboard.c: noXkbExtension is a Boolean | Ulrich Sibiller | 2021-01-15 | 1 | -2/+2 | |
| | ||||||
* | Font.c: Use Booleans where appropriate | Ulrich Sibiller | 2021-01-15 | 1 | -16/+16 | |
| | ||||||
* | nxagent: make nxagentXkbState.Initialized a Boolean | Ulrich Sibiller | 2021-01-15 | 4 | -7/+6 | |
| | ||||||
* | Events.h: fix wrong prototype | Ulrich Sibiller | 2021-01-15 | 1 | -1/+1 | |
| | ||||||
* | nxagent: make nxagentXFixesInfo.Initialized a Boolean | Ulrich Sibiller | 2021-01-15 | 3 | -4/+4 | |
| | ||||||
* | Drawable.c: make doRoundRobin a Boolean | Ulrich Sibiller | 2021-01-15 | 1 | -4/+4 | |
| | ||||||
* | Handlers.c: make synchronize a Boolean variable | Ulrich Sibiller | 2021-01-15 | 1 | -3/+3 | |
| | ||||||
* | nxagent: make nxagentSkipImage a Boolean | Ulrich Sibiller | 2021-01-15 | 2 | -3/+3 | |
| | ||||||
* | nxagent: make nxagentForceSynchronization a Boolean | Ulrich Sibiller | 2021-01-15 | 5 | -6/+6 | |
| | ||||||
* | Drawable.c: make abort flag a Boolean | Ulrich Sibiller | 2021-01-15 | 2 | -17/+17 | |
| | ||||||
* | Client.c: cleanup Boolean handling for nxagentNeedWakeup*() macros | Ulrich Sibiller | 2021-01-15 | 1 | -6/+6 | |
| | ||||||
* | GC.c: make internal variable and function Boolean | Ulrich Sibiller | 2021-01-15 | 1 | -16/+16 | |
| | ||||||
* | GCOps.c: make internal variable an function Booleans | Ulrich Sibiller | 2021-01-15 | 1 | -14/+14 | |
| | ||||||
* | nxagent: make nxagentBlocking an Boolean | Ulrich Sibiller | 2021-01-15 | 5 | -13/+13 | |
| | ||||||
* | Render.c: improve Boolean handling of nxagentCheckPictureRemoteValue | Ulrich Sibiller | 2021-01-15 | 1 | -12/+12 | |
| | ||||||
* | nxagent: improve Boolean handling for Reconnect functions | Ulrich Sibiller | 2021-01-15 | 2 | -20/+20 | |
| | ||||||
* | nxagent: make XDMCP variables Booleans | Ulrich Sibiller | 2021-01-15 | 3 | -10/+10 | |
| | ||||||
* | GCOps.c: make internal function Boolean | Ulrich Sibiller | 2021-01-15 | 1 | -6/+6 | |
| | ||||||
* | GCOps.c: handle some internal variables as Booleans | Ulrich Sibiller | 2021-01-15 | 1 | -5/+5 | |
| | ||||||
* | Drawable.c: make some variables Booleans | Ulrich Sibiller | 2021-01-15 | 1 | -5/+5 | |
| | ||||||
* | nxagent: handle RegionNil macro as Boolean | Ulrich Sibiller | 2021-01-15 | 8 | -33/+33 | |
| | | | | just as the rest of the Xserver is alsow doing | |||||
* | Split.c, Image.c: make some internal variables Booleans | Ulrich Sibiller | 2021-01-15 | 2 | -29/+29 | |
| | ||||||
* | nxagent: rework some Boolean checks | Ulrich Sibiller | 2021-01-15 | 7 | -10/+10 | |
| | | | | | nxagentWindowTopLevel() and nxagentNeedConnectionChange() return Boolean nxagentPixmapIsVirtual() and nxagentIsShmPixmap(), too. | |||||
* | nxagent: make nxagentUserDefinedFontPath a Boolean | Ulrich Sibiller | 2021-01-15 | 3 | -4/+4 | |
| | ||||||
* | nxagent: make nxagentShadowResize a Boolean | Ulrich Sibiller | 2021-01-15 | 4 | -5/+5 | |
| | ||||||
* | nxagent: make nxagentDoFullgeneration a Boolean | Ulrich Sibiller | 2021-01-15 | 3 | -3/+3 | |
| | ||||||
* | nxagent: some more Boolean improvements | Ulrich Sibiller | 2021-01-15 | 1 | -2/+2 | |
| | ||||||
* | nxagent: treat nxagentLastWindowDestroyed as Boolean | Ulrich Sibiller | 2021-01-15 | 2 | -2/+2 | |
| | ||||||
* | nxagent: treat all Traps as Booleans everywhere | Ulrich Sibiller | 2021-01-15 | 12 | -67/+67 | |
| | ||||||
* | nxagent: make nxagentVerbose a Boolean | Ulrich Sibiller | 2021-01-15 | 6 | -9/+9 | |
| | ||||||
* | nxagent: make Desktop, Rootless and Binder options Booleans (again) | Ulrich Sibiller | 2021-01-15 | 11 | -56/+33 | |
| | | | | | They have been changed to tri-state variables (1, 0 and UNDEFINED) between nxagent 1.5.0-90 and -93, for no obvious reason. | |||||
* | Options.h: mark Booleans | Ulrich Sibiller | 2021-01-15 | 1 | -26/+32 | |
| | | | | | Many variables are used as Booleans. By adding the Bool define to Options.h we can now make that visible. | |||||
* | nxagent: make nxagentOption Shadow a Boolean | Ulrich Sibiller | 2021-01-15 | 9 | -25/+26 | |
| | | | | and add the missing init code. | |||||
* | nxagent: treat several nxagentOptions as real Booleans | Ulrich Sibiller | 2021-01-15 | 16 | -77/+77 | |
| | | | | | | | Adaptive, Composite, DeviceControl, DeviceControlUserDefined, IgnoreVisibility, InhibitXkb, Nested, Menu, MagicPixel, Persistent, Reset, ResetzKeyboardAtResume, SharedMemory, SharedPixmaps, Streaming, UseDamage, ViewOnly, Xdmcp, Xinerama | |||||
* | nxagent: treat DesktopResize and nxagentResizeDesktopAtStartup as Booleans | Ulrich Sibiller | 2021-01-15 | 6 | -19/+19 | |
| | | | | The already where Booleans but where not using True/False values everywhere |