aboutsummaryrefslogtreecommitdiff
path: root/nx-X11
Commit message (Collapse)AuthorAgeFilesLines
* Client.c: cleanup Boolean handling for nxagentNeedWakeup*() macrosUlrich Sibiller2021-01-151-6/+6
|
* GC.c: make internal variable and function BooleanUlrich Sibiller2021-01-151-16/+16
|
* GCOps.c: make internal variable an function BooleansUlrich Sibiller2021-01-151-14/+14
|
* nxagent: make nxagentBlocking an BooleanUlrich Sibiller2021-01-155-13/+13
|
* Render.c: improve Boolean handling of nxagentCheckPictureRemoteValueUlrich Sibiller2021-01-151-12/+12
|
* nxagent: improve Boolean handling for Reconnect functionsUlrich Sibiller2021-01-152-20/+20
|
* nxagent: make XDMCP variables BooleansUlrich Sibiller2021-01-153-10/+10
|
* GCOps.c: make internal function BooleanUlrich Sibiller2021-01-151-6/+6
|
* GCOps.c: handle some internal variables as BooleansUlrich Sibiller2021-01-151-5/+5
|
* Drawable.c: make some variables BooleansUlrich Sibiller2021-01-151-5/+5
|
* nxagent: handle RegionNil macro as BooleanUlrich Sibiller2021-01-158-33/+33
| | | | just as the rest of the Xserver is alsow doing
* Split.c, Image.c: make some internal variables BooleansUlrich Sibiller2021-01-152-29/+29
|
* nxagent: rework some Boolean checksUlrich Sibiller2021-01-157-10/+10
| | | | | nxagentWindowTopLevel() and nxagentNeedConnectionChange() return Boolean nxagentPixmapIsVirtual() and nxagentIsShmPixmap(), too.
* nxagent: make nxagentUserDefinedFontPath a BooleanUlrich Sibiller2021-01-153-4/+4
|
* nxagent: make nxagentShadowResize a BooleanUlrich Sibiller2021-01-154-5/+5
|
* nxagent: make nxagentDoFullgeneration a BooleanUlrich Sibiller2021-01-153-3/+3
|
* nxagent: some more Boolean improvementsUlrich Sibiller2021-01-151-2/+2
|
* nxagent: treat nxagentLastWindowDestroyed as BooleanUlrich Sibiller2021-01-152-2/+2
|
* nxagent: treat all Traps as Booleans everywhereUlrich Sibiller2021-01-1512-67/+67
|
* nxagent: make nxagentVerbose a BooleanUlrich Sibiller2021-01-156-9/+9
|
* nxagent: make Desktop, Rootless and Binder options Booleans (again)Ulrich Sibiller2021-01-1511-56/+33
| | | | | They have been changed to tri-state variables (1, 0 and UNDEFINED) between nxagent 1.5.0-90 and -93, for no obvious reason.
* Options.h: mark BooleansUlrich Sibiller2021-01-151-26/+32
| | | | | Many variables are used as Booleans. By adding the Bool define to Options.h we can now make that visible.
* nxagent: make nxagentOption Shadow a BooleanUlrich Sibiller2021-01-159-25/+26
| | | | and add the missing init code.
* nxagent: treat several nxagentOptions as real BooleansUlrich Sibiller2021-01-1516-77/+77
| | | | | | | Adaptive, Composite, DeviceControl, DeviceControlUserDefined, IgnoreVisibility, InhibitXkb, Nested, Menu, MagicPixel, Persistent, Reset, ResetzKeyboardAtResume, SharedMemory, SharedPixmaps, Streaming, UseDamage, ViewOnly, Xdmcp, Xinerama
* nxagent: treat DesktopResize and nxagentResizeDesktopAtStartup as BooleansUlrich Sibiller2021-01-156-19/+19
| | | | The already where Booleans but where not using True/False values everywhere
* nxagent: make Fullscreen and AllScreens BooleansUlrich Sibiller2021-01-156-35/+29
| | | | | There's no need/sense in having a tri-state with the third state being UNDEFINED.
* Handlers.c: ensure regular yields if suspendedUlrich Sibiller2021-01-151-1/+22
| | | | Fixes ArcticaProject/nx-libs#903
* CVE-2020-14360: Check SetMap request length carefully.Mike Gabriel2021-01-151-0/+91
| | | | | | | | | | | | | | | | | | Backported from X.org: From 446ff2d3177087b8173fa779fa5b77a2a128988b Mon Sep 17 00:00:00 2001 From: Matthieu Herrb <matthieu@herrb.eu> Date: Thu, 12 Nov 2020 19:15:07 +0100 Subject: [PATCH] Check SetMap request length carefully. Avoid out of bounds memory accesses on too short request. ZDI-CAN 11572 / CVE-2020-14360 This vulnerability was discovered by: Jan-Niklas Sohn working with Trend Micro Zero Day Initiative Fixes ArcticaProject/nx-libs#972.
* Init.c: Initialize nxagentGrabServerInfoUlrich Sibiller2021-01-121-1/+8
| | | | Fixes ArcticaProject/nx-libs#983
* Events.c: fix leftover DEBUG and TEST definitionsUlrich Sibiller2020-12-031-4/+1
| | | | causing DEBUG output in regular builds.
* NXdixfonts.c: Regression fix for db45683a. Fix typo in libXfont1 function ↵Mike Gabriel2020-11-041-1/+1
| | | | call (FreeFontName -> FreeFontNames). Fixes FTBFS on Ubuntu 14.04 and 16.04.
* release 3.5.99.253.5.99.25Mike Gabriel2020-11-042-1/+1
|
* NXdixfonts.c: Hard-code the enablement of NXAGENT_DANGEROUS_XFONT_LOOP_EXIT.Mike Gabriel2020-11-041-0/+7
|
* NXdixfonts.c: Rename BREAK_XFONT_LOOP to NXAGENT_DANGEROUS_XFONT_LOOP_EXIT ↵Mike Gabriel2020-11-041-4/+4
| | | | (better macro name).
* Clipboard.c: fix bug in special optimization for nested settingsUlrich Sibiller2020-11-041-2/+3
| | | | Fixes ArcticaProject/nx-libs#941
* compext/Png.c: fix shadowingUlrich Sibiller2020-11-031-3/+3
| | | | | | | | | | | | | | | | | Png.c: In function ‘PngWriteData’: Png.c:603:38: warning: declaration of ‘png_ptr’ shadows a global declaration [-Wshadow] 603 | static void PngWriteData(png_structp png_ptr, png_bytep data, png_size_t length) | ~~~~~~~~~~~~^~~~~~~ Png.c:77:13: note: shadowed declaration is here 77 | png_structp png_ptr; | ^~~~~~~ Png.c: In function ‘PngFlushData’: Png.c:610:38: warning: declaration of ‘png_ptr’ shadows a global declaration [-Wshadow] 610 | static void PngFlushData(png_structp png_ptr) | ~~~~~~~~~~~~^~~~~~~ Png.c:77:13: note: shadowed declaration is here 77 | png_structp png_ptr; | ^~~~~~~
* Screen.c: fix indentation in nxagentMaximizeToFullScreenUlrich Sibiller2020-11-031-37/+37
|
* Atoms.c: fix FIXME commentUlrich Sibiller2020-11-031-1/+1
|
* Atoms.c: improve debug outputUlrich Sibiller2020-11-031-1/+1
|
* Events.c: scope improvementUlrich Sibiller2020-11-031-2/+2
|
* Xext/panoramiX.c: rename shadowing variablesUlrich Sibiller2020-11-031-7/+7
|
* Clipboard.c: add missing ifdefsUlrich Sibiller2020-11-031-0/+6
|
* Compext.c: scope improvementsUlrich Sibiller2020-11-031-14/+6
|
* GCs.h: fix typoUlrich Sibiller2020-11-031-1/+1
|
* Atoms.c: drop double includeUlrich Sibiller2020-11-031-1/+0
|
* Compext.c: use SAFE_free macroUlrich Sibiller2020-11-034-169/+106
|
* Clipboard.c: fix missing )Ulrich Sibiller2020-11-031-1/+1
|
* NXdixfonts.c: fix memory leakUlrich Sibiller2020-11-031-6/+56
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ==15332== 2,500 (96 direct, 2,404 indirect) bytes in 6 blocks are definitely lost in loss record 324 of 342 ==15332== at 0x4C2DB8F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==15332== by 0x5748B9E: FontFileStartListFonts (in /usr/lib/x86_64-linux-gnu/libXfont.so.1.4.1) ==15332== by 0x5748C4A: FontFileStartListFontsAndAliases (in /usr/lib/x86_64-linux-gnu/libXfont.so.1.4.1) ==15332== by 0x42859A: nxdoListFontsAndAliases (NXdixfonts.c:1163) ==15332== by 0x42C0E0: nxOpenFont (NXdixfonts.c:1541) ==15332== by 0x43392E: ProcOpenFont (NXdispatch.c:902) ==15332== by 0x434585: Dispatch (NXdispatch.c:482) ==15332== by 0x40EF77: main (main.c:355) FontFileStartListFonts[AndAliases]() allocates some private data. This data is used by subsequent calls of FontFileListNextFontOrAlias() in a loop. (Only) the last call to that function will free() the private data and return with BadFontName. FontFileListNextFontOrAlias() is the only libXfont function that free()s the private data. In nxagent the loop is exited as soon as a font exists both locally and remote. Therefore the private data would never be free()d. Solution: do not break the loop but store the first matching result and let the loop run to the end, ignoring all following results. Disadvantage: this can mean hundreds of extra iterations for nothing. I have done no investigation of the time penalty this might cause. Unfortunately this is the only clean way I have found so far. An unclean solution has also been implemented. It can be activated by defining BREAK_XFONT_LOOP. In that case the private data is handled in nxagent by taking assumptions about its structure (taken from the libXfont source). That will break if libXfont changes its internal handling of the private. Therefore it is discouraged. An third alternative would be to drop using libXfont from the system. Instead fork libXfont to the nx-libs tree, add some patches link to that library statically. Fixes ArcticaProject/nx-libs#586
* yConnDis.c: fix memory leakUlrich Sibiller2020-11-031-12/+28
| | | | | | | | | | | | | | | | | | Direct leak of 3 byte(s) in 1 object(s) allocated from: #0 0xb79e85d4 in __interceptor_malloc (/lib/i386-linux-gnu/libasan.so.5+0xeb5d4) #1 0xb770b635 in copystring /home/uli/work/nx/nx-libs/nx-X11/lib/src/ConnDis.c:96 #2 0xb770ba56 in _X11TransConnectDisplay /home/uli/work/nx/nx-libs/nx-X11/lib/src/ConnDis.c:229 #3 0xb776b4fd in XOpenDisplay /home/uli/work/nx/nx-libs/nx-X11/lib/src/OpenDis.c:215 #4 0x63e2fd in nxagentInternalOpenDisplay /home/uli/work/nx/nx-libs/nx-X11/programs/Xserver/hw/nxagent/Display.c:608 #5 0x63fa03 in nxagentOpenDisplay /home/uli/work/nx/nx-libs/nx-X11/programs/Xserver/hw/nxagent/Display.c:1140 #6 0x694b5a in InitOutput /home/uli/work/nx/nx-libs/nx-X11/programs/Xserver/hw/nxagent/Init.c:305 #7 0x5f7b11 in main /home/uli/work/nx/nx-libs/nx-X11/programs/Xserver/dix/main.c:278 #8 0xb6f04b40 in __libc_start_main ../csu/libc-start.c:308 I have not investigated the exact location where an XFree() was missing but added multiple Xfree() calls whereever appropriate. Fixes ArcticaProject/nx-libs#951
* Events.c: More cosmeticsUlrich Sibiller2020-10-171-7/+9
|