| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| |
|
|
|
|
| |
remove unneccessary parentheses
|
|
|
|
|
|
|
|
| |
make it compile again
Thanks to Simon Matter for reporting this and the patch.
Fixes ArcticaProject/nx-libs#993
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
See,
$ find . -name "*.sh" | xargs shellcheck -i SC2048
In ./nx-X11/lib/src/util/mkks.sh line 10:
}' $*
^-- SC2048: Use "$@" (with quotes) to prevent whitespace problems.
For more information:
https://www.shellcheck.net/wiki/SC2048 -- Use "$@" (with quotes) to prevent...
Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
| |
See,
$ find . -name "*.sh" | xargs shellcheck -i SC2002
For more information:
https://www.shellcheck.net/wiki/SC2002 -- Useless cat. Consider 'cmd < file...
Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
See,
$ find . -name "*.sh" | xargs shellcheck -i SC2006
In ./roll-tarballs.sh line 62:
echo "HEAD (on branch `git rev-parse --abbrev-ref HEAD`)"
^-- SC2006: Use $(...) notation instead of legacy backticked `...`.
Did you mean:
echo "HEAD (on branch $(git rev-parse --abbrev-ref HEAD))"
In ./nx-X11/x-indent-all.sh line 2:
where=`dirname $0`
^----------^ SC2006: Use $(...) notation instead of legacy backticked `...`.
Did you mean:
where=$(dirname $0)
In ./nx-X11/x-indent.sh line 5:
INDENT=`which gnuindent || which gindent || which indent`
^-- SC2006: Use $(...) notation instead of legacy backticked `...`.
Did you mean:
INDENT=$(which gnuindent || which gindent || which indent)
For more information:
https://www.shellcheck.net/wiki/SC2006 -- Use $(...) notation instead of le...
Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>
|
|
|
|
|
|
| |
We can now also drop all remaining NX specific lines from the security.c
see ArcticaProject/nx-libs#988
|
|
|
|
|
|
|
|
| |
This reflects the path where the file is placed after installation.
It also obsoletes the NX_ALTERNATIVEPOLICYFILE.
Fixes ArcticaProject/nx-libs#988
|
| |
|
|
|
|
| |
Fixes ArcticaProject/nx-libs#987
|
|
|
|
|
|
| |
Is required for compilations with musl.
See ArcticaProjects/nx-libs#975 and ArcticaProjects/nx-libs#976
|
|
|
|
| |
Fixes ArcticaProject/nx-lib#975
|
| |
|
|
|
|
|
|
|
|
| |
This used to be printed only in TEST mode. Some while ago I had
changed that to WARNING (because it is a warning...). However, this
happens e.g. when running the xscreensaver vfeedback module and it
does not look like it is a problem at all. So let's suppress this
warning again and leave it to the TEST mode as it used to be.
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
although there is no functional difference...
|
| |
|
| |
|
|
|
|
| |
PVS finding: "V522 There might be dereferencing of a potential null pointer 'props'"
|
|
|
|
| |
PVS finding: "V522 There might be dereferencing of a potential null pointer 'nxagentConfiguredWindowList'."
|
|
|
|
| |
PVS finding: "V522 There might be dereferencing of a potential null pointer"
|
|
|
|
| |
PVs finding: "V547 Expression '!nxagentWMPassed' is always true."
|
|
|
|
| |
"V547 Expression 'wmHints.input == 1' is always true."
|
|
|
|
| |
PVS Studio: "V614 Potentially uninitialized variable 'glyphBox.*' used."
|
|
|
|
|
|
| |
"V701 realloc() possible leak: when realloc() fails in allocating
memory, original pointer 'nxagentReconnectErrorMessage' is
lost. Consider assigning realloc() to a temporary pointer."
|
|
|
|
|
| |
"V575 The potential null pointer is passed into 'memcpy'
function. Inspect the first argument."
|
|
|
|
|
| |
found by PVS Studio: "V522 There might be dereferencing of a potential
null pointer 'keymap'."
|
|
|
|
|
| |
"V560 A part of conditional expression is always true: oldStatus ==
NotSynchronized."
|
|
|
|
|
|
| |
"V701 realloc() possible leak: when realloc() fails in allocating
memory, original pointer 'nxagentDefaultColormaps' is lost. Consider
assigning realloc() to a temporary pointer."
|
|
|
|
|
| |
"V575 The potential null pointer is passed into 'strlen'
function. Inspect the first argument. Check lines: 420, 403."
|
|
|
|
|
|
|
| |
Code can only be reached if pPicture is non-NULL. Besides, pPicture
will be accessed later anyway, regardless of this check.
Finding of PVS Studio: "V547 Expression 'pPicture != NULL' is always true."
|
|
|
|
| |
Based on PVS Studio finding: "V547 Expression 'data' is always true."
|
|
|
|
|
|
|
|
| |
success would always be true at the beginning of the loop as it is part
of the loop condition.
Finding from PVS Studio: "V560 A part of conditional expression is
always true: success."
|
|
|
|
|
|
| |
PVS Studio: "V592 The expression was enclosed by parentheses twice:
'((* pRed * (limg + 1)))'. One pair of parentheses is unnecessary or
misprint is present."
|
|
|
|
|
|
| |
"V701 realloc() possible leak: when realloc() fails in allocating
memory, original pointer 'privAtomMap' is lost. Consider assigning
realloc() to a temporary pointer."
|
| |
|
|
|
|
|
| |
FIX PVS Studio finding "V575 The potential null pointer is passed into
'strlen' function. Inspect the first argument"
|
|
|
|
|
|
|
|
| |
fullscreen= now accepts the new value "2" for a fullscreen covering
only one screen. -geometry and geometry= now know additional keywords
"allscreens" and "onescreen".
Fixes ArcticaProject/nx-libs#923
|
|
|
|
| |
This reverts commit 4eba4f53ad8c62c27c12835e58184d66121ff636.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|