aboutsummaryrefslogtreecommitdiff
path: root/nxcomp/Proxy.cpp
Commit message (Collapse)AuthorAgeFilesLines
* Clean up compiler warnings in nxcompFernando Carvajal2016-04-271-48/+102
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit removes several warnings in nxcomp related to unused but set variables. It also replaces tempnam function with the more secure one mkstemp and there has been removed another warning related to setgid and setuid returning values not being checked. So these were the compiler warnings in nxcomp that have been fixed: Loop.cpp: In function ‘int ParseRemoteOptions(char*)’: Loop.cpp:9423:7: warning: variable ‘hasLimit’ set but not used [-Wunused-but-set-variable] int hasLimit = 0; ^ Loop.cpp:9424:7: warning: variable ‘hasRender’ set but not used [-Wunused-but-set-variable] int hasRender = 0; ^ Loop.cpp:9425:7: warning: variable ‘hasTaint’ set but not used [-Wunused-but-set-variable] int hasTaint = 0; ^ Loop.cpp:9427:7: warning: variable ‘hasStrict’ set but not used [-Wunused-but-set-variable] int hasStrict = 0; ^ Loop.cpp:9428:7: warning: variable ‘hasShseg’ set but not used [-Wunused-but-set-variable] int hasShseg = 0; ^ ServerChannel.cpp: In member function ‘virtual int ServerChannel::handleWrite(const unsigned char*, unsigned int)’: ServerChannel.cpp:2132:9: warning: variable ‘hit’ set but not used [-Wunused-but-set-variable] int hit; ^ Proxy.o: In function `Proxy::handleSaveAllStores(char const*) const': Proxy.cpp:(.text+0x2cac): warning: the use of `tempnam' is dangerous, better use `mkstemp' Pipe.cpp: In function ‘FILE* Popen(char* const*, const char*)’: Pipe.cpp:240:23: warning: ignoring return value of ‘int setgid(__gid_t)’, declared with attribute warn_unused_result [-Wunused-result] setgid(getgid()); ^ Pipe.cpp:241:23: warning: ignoring return value of ‘int setuid(__uid_t)’, declared with attribute warn_unused_result [-Wunused-result] setuid(getuid()); ^ There was also a hidden problem in the way Proxy::handleSaveAllStores was checking for an error in the returning value from the call to the virtual method handleSaveAllStores of the specific proxy class really being used (ClientProxy or ServerProxy). Former code was considering the value 0 as the returning value in case of an error whereas both subclasses return the value -1 when there is an error in their handleSaveAllStores method. This bug has been fixed in this commit taking advantage of the modification that was already being made to this method in order to replace tempnam function with the more secure one mkstemp. Fixes: ArcticaProject/nx-libs#103
* Remove compatibility code for nxcomp before 3.5.0Fernando Carvajal2016-04-121-203/+77
| | | | | | | | | | | | | | As a part of nxcomp's clean-up process, compatibility with old protocol versions has been set now at 3.5.0. This commit removes compatibility code from nxcomp so the minimum supported version changes from 1.5.0 (protocol step 6) to 3.5.0 (protocol step 10). At this moment the removal is not complete and it will be followed by some other commits, in order to get rid of several components and files that are no longer used as they were only needed to work with old protocol versions. Refs: ArcticaProject/nx-libs#108
* This patch is some code fixes to debug some debuging macro usage in the NX code.Nito Martinez2015-05-151-1/+1
| | | | Particularly the following macros have been tested -DTEST -DDEBUG -DDUMP -DFLUSH -DTOKEN -DSPLIT -DPING -DMIXED -DMATCH -DTIME
* Fix FTBFS of nxproxy/nxcomp on Android ↵Nito Martinez2015-02-101-0/+7
| | | | (212_nxcomp_build-on-Android.full+lite.patch).
* Description: gcc43 fix (005_nxcomp_gcc43.full+lite.patch)Marcelo Boveto Shima2015-02-091-2/+2
| | | | Use builtin includes to build with gcc43.
* Revert "release 3.5.0.19"Mike Gabriel2013-03-281-2/+2
| | | | This reverts commit e77bf36d9afbc7e56522574b06217d57c11dd095.
* release 3.5.0.19Mike Gabriel2013-03-281-2/+2
|
* Imported nxcomp-3.5.0-2.tar.gznxcomp/3.5.0-2nxcompReinhard Tartler2011-11-131-1/+18
| | | | | | | | Summary: Imported nxcomp-3.5.0-2.tar.gz Keywords: Imported nxcomp-3.5.0-2.tar.gz into Git repository
* Imported nxcomp-3.4.0-6.tar.gznxcomp/3.4.0-6Reinhard Tartler2011-11-131-2/+2
| | | | | | | | Summary: Imported nxcomp-3.4.0-6.tar.gz Keywords: Imported nxcomp-3.4.0-6.tar.gz into Git repository
* Imported nxcomp-3.4.0-1.tar.gznxcomp/3.4.0-1Reinhard Tartler2011-11-131-2/+2
| | | | | | | | Summary: Imported nxcomp-3.4.0-1.tar.gz Keywords: Imported nxcomp-3.4.0-1.tar.gz into Git repository
* Imported nxcomp-3.3.0-4.tar.gznxcomp/3.3.0-4Reinhard Tartler2011-11-131-1/+1
| | | | | | | | Summary: Imported nxcomp-3.3.0-4.tar.gz Keywords: Imported nxcomp-3.3.0-4.tar.gz into Git repository
* Imported nxcomp-3.2.0-7.tar.gznxcomp/3.2.0-7Reinhard Tartler2011-11-131-1/+2
| | | | | | | | Summary: Imported nxcomp-3.2.0-7.tar.gz Keywords: Imported nxcomp-3.2.0-7.tar.gz into Git repository
* Imported nxcomp-3.1.0-6.tar.gznxcomp/3.1.0-6Reinhard Tartler2011-11-131-23/+11
| | | | | | | | Summary: Imported nxcomp-3.1.0-6.tar.gz Keywords: Imported nxcomp-3.1.0-6.tar.gz into Git repository
* Imported nxcomp-3.1.0-4.tar.gznxcomp/3.1.0-4Reinhard Tartler2011-11-131-0/+6444
Summary: Imported nxcomp-3.1.0-4.tar.gz Keywords: Imported nxcomp-3.1.0-4.tar.gz into Git repository
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-21 23:06:08 +0000