| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
being TCP/IP sockets.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This commit removes several warnings in nxcomp related to unused but
set variables. It also replaces tempnam function with the more secure
one mkstemp and there has been removed another warning related to
setgid and setuid returning values not being checked.
So these were the compiler warnings in nxcomp that have been fixed:
Loop.cpp: In function ‘int ParseRemoteOptions(char*)’:
Loop.cpp:9423:7: warning: variable ‘hasLimit’ set but not used [-Wunused-but-set-variable]
int hasLimit = 0;
^
Loop.cpp:9424:7: warning: variable ‘hasRender’ set but not used [-Wunused-but-set-variable]
int hasRender = 0;
^
Loop.cpp:9425:7: warning: variable ‘hasTaint’ set but not used [-Wunused-but-set-variable]
int hasTaint = 0;
^
Loop.cpp:9427:7: warning: variable ‘hasStrict’ set but not used [-Wunused-but-set-variable]
int hasStrict = 0;
^
Loop.cpp:9428:7: warning: variable ‘hasShseg’ set but not used [-Wunused-but-set-variable]
int hasShseg = 0;
^
ServerChannel.cpp: In member function ‘virtual int ServerChannel::handleWrite(const unsigned char*, unsigned int)’:
ServerChannel.cpp:2132:9: warning: variable ‘hit’ set but not used [-Wunused-but-set-variable]
int hit;
^
Proxy.o: In function `Proxy::handleSaveAllStores(char const*) const':
Proxy.cpp:(.text+0x2cac): warning: the use of `tempnam' is dangerous, better use `mkstemp'
Pipe.cpp: In function ‘FILE* Popen(char* const*, const char*)’:
Pipe.cpp:240:23: warning: ignoring return value of ‘int setgid(__gid_t)’,
declared with attribute warn_unused_result [-Wunused-result]
setgid(getgid());
^
Pipe.cpp:241:23: warning: ignoring return value of ‘int setuid(__uid_t)’,
declared with attribute warn_unused_result [-Wunused-result]
setuid(getuid());
^
There was also a hidden problem in the way Proxy::handleSaveAllStores was
checking for an error in the returning value from the call to the virtual
method handleSaveAllStores of the specific proxy class really being used
(ClientProxy or ServerProxy).
Former code was considering the value 0 as the returning value in case of
an error whereas both subclasses return the value -1 when there is an error
in their handleSaveAllStores method.
This bug has been fixed in this commit taking advantage of the modification
that was already being made to this method in order to replace tempnam
function with the more secure one mkstemp.
Fixes: ArcticaProject/nx-libs#103
|
|
|
|
|
|
| |
It was GPL3 instead of GPL2!
Fixes ArcticaProject/nx-libs#112
|
|
|
|
|
|
|
|
|
|
|
|
| |
This commit removes TextCompressor class references from ClientCache
and ServerCache as it's no longer used after removing old protocol's
compatibility code from nxcomp. It also removes the attribute textCache
from both classes as it's no longer used either.
Finally the header and source files associated with the TextCompressor
class are also deleted and removed from the compilation process.
Refs: ArcticaProject/nx-libs#108
|
|
|
|
|
|
|
|
| |
This commit removes obsolete compatibility files whose components were
only used to handle compatibility with old protocol versions that are
no longer supported.
Refs: ArcticaProject/nx-libs#108
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As a part of nxcomp's clean-up process, compatibility with old protocol
versions has been set now at 3.5.0.
This commit removes compatibility code from nxcomp so the minimum supported
version changes from 1.5.0 (protocol step 6) to 3.5.0 (protocol step 10).
At this moment the removal is not complete and it will be followed by some
other commits, in order to get rid of several components and files that are
no longer used as they were only needed to work with old protocol versions.
Refs: ArcticaProject/nx-libs#108
|
|
|
|
| |
Fixes ArcticaProject/nx-libs#104
|
| |
|
|
|
|
| |
$DISPLAY variable.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
By design, when resuming a session, Xinerama can only be re-enabled
by NX option parsing.
Thus, this change introduces a "xinerama" NX option that can
be loaded via an options file into NX agent when resuming
a session. The new xinerame NX session option also allows
switching on Xinerama at session startup via an option file.
When implementing the new NX Xinerama support into clients (like
TheQVD, X2Go Client, etc., this new xinerama NX option should be
used for activating Xinerama in the NX / QVD / X2Go session.
|
|\
| |
| | |
Various fixes for pkgconfig file creation.
|
| | |
|
| | |
|
| | |
|
|/ |
|
| |
|
| |
|
|\
| |
| | |
Fix negotiation in stage 10 error.
|
| |
| |
| |
| |
| | |
Problem fixed by adding a select() call to implement a timeout,
and retrying writes if needed.
|
| |
| |
| |
| | |
fixes.
|
| |
| |
| |
| | |
1f44331574bdbe4069d13e4c26df18094b49e658.
|
|/
|
|
|
|
|
|
|
|
|
| |
* Update nxcomp/LICENSE.
* Add nxcomp/README.on-retroactive-DXPC-license, giving a
short overview of the flow of discussions
* Add "modified or unmodified" to the license information
printed out to stdout in nxcomp/Misc.cpp
* Fix copyright year (2006->2003) for Gian Filippo Pinzari
(and move him to the GPL-2 section).
* Add the complete .mbox file of Debian bug #748565.
|
|\
| |
| | |
This patch is some code fixes to allow developer debuging by using TEST macros in the NX code
|
| |
| |
| |
| | |
Particularly the following macros have been tested -DTEST -DDEBUG -DDUMP -DFLUSH -DTOKEN -DSPLIT -DPING -DMIXED -DMATCH -DTIME
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
connection inside the same process, instead of a new process as is the nxproxy case.
This involves creating a new API call
void NXTransCleanupForReconnect(void);
which basically cleans up the global state for the connection but does not exit the process.
Background
==========
This is needed for the IOS platform, where the nxproxy model of forking does not work.
Also NX handles most of the errors with an "exit" call which in IOS cannot be easily handled.
|
|
|
|
| |
current_version on OS X. ld(1) on 10.6 fails otherwise.
|
|
|
|
| |
if it is not available.
|
|
|
|
| |
from other UNIX-based systems.
|
|
|
|
| |
of -bundle.
|
|
|
|
| |
old cruft.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
nx*/VERSION and hw/nxagent/VERSION.
This commit removes the debian/VERSION file at makes it now unnecessary to
copy/symlink the VERSION file at build time. These build scripts got adapted:
debian/roll-tarballs.sh
debian/rules
nx-libs.spec
Furthermore, all NX component now use the main VERSION file as reference.
typechange: nxcomp/VERSION
typechange: nxcompext/VERSION
typechange: nxcompshad/VERSION
typechange: nxproxy/VERSION
|
|
|
|
| |
d4d3fe0e6e77a58e68defc5895a589a681d7d092.
|
|
|
|
|
|
| |
Former patch file names:
991_fix-hr-typos.full+lite.patch
991_fix-hr-typos.full.patch
|
|
|
|
| |
(607_nxcomp_macosx-X11-launcher-in-private-tmp.full+lite.patch).
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(605_nxcomp_Types.h-dont-use-STL-internals-on-libc++.full+lite.patch).
The nx-libs-lite package does not compile on OS X Mavericks because
Apple's clang compilers now default to compiling against the libc++ STL
rather than (their outdated copy of) libstdc++.
While the compiler still allows changing that, we should not rely on
this being possible forever.
The compiler chokes in Types.h, specifically the clear() methods in
subclasses of vectors that use implementation details of the GNU STL.
The attached patch fixes these compilation issues by not overriding the
clear() method when compiling against libc++, since the libc++ headers
seem to do essentially the same as the overriden method.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
relinquishing privileges (602_nx-X11_initgroups.full.patch).
The Fedora review of NX (redistributed) caught the following rpmlint issue:
This executable is calling setuid and setgid without setgroups or initgroups.
There is a high probability this mean it didn't relinquish all groups, and this
would be a potential security issue to be fixed. Seek POS36-C on the web for
details about the problem.
Ref POS36-C:
https://www.securecoding.cert.org/confluence/display/seccode/POS36-C.+Observe+correct+revocation+order+while+relinquishing+privileges
This patch adds initgroups() calls to the code to initialize the supplemental group list.
|
|
|
|
| |
(400_nxcomp-version.full+lite.patch).
|
|
|
|
| |
(220_nxproxy_bind-loopback-only.full+lite.patch).
|
|
|
|
| |
(212_nxcomp_build-on-Android.full+lite.patch).
|
|
|
|
| |
(211_nxcomp_set_default_options.full+lite.patch).
|
|
|
|
|
|
|
|
|
| |
210_nxagent_save_session_state.full.patch
210_nxcomp_save_session_state.full+lite.patch
This patch adds a "state" option to NX (agent) which
allows one to specify a file where nxagent will write
its session state into.
|
|
|
|
| |
(052_nxcomp_macos10-nxauth-location.full+lite.patch)
|
|
|
|
|
|
|
|
|
|
|
| |
The Mac OS X 10.5 SDK requires the second argument of FD_ISSET to be
writeable, although it does only access the data. Given that we have a
const pointer for a const struct, copy and pass that.
.
Note that this is merely a workaround for OS X 10.5, as 10.6 and later
define the second argument of FD_ISSET as const struct const *foo, too.
.
It is safe, as data is accessed read-only by FD_ISSET, even on 10.5.
|
|
|
|
| |
(029_nxcomp_ppc64.full+lite.patch)
|
|
|
|
| |
(027_nxcomp_abstract-X11-socket.full+lite.patch).
|
|
|
|
|
|
| |
026_nxcompext_honour-optflags.full.patch
026_nxcomp_honour-optflags.full+lite.patch
026_nxcompshad_honour-optflags.full.patch
|
|
|
|
| |
(025_nxcomp-fix-ftbfs-against-jpeg9a.full+lite.patch).
|
|
|
|
|
| |
024_fix-make-clean.full.patch
024_fix-make-clean.full+lite.patch
|
| |
|