Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Revert "Fix parsing ports set to unix sockets" | Mike Gabriel | 2019-02-20 | 1 | -5/+1 |
| | | | | | | This reverts commit 889de46f759913742478d2cfe20f1f4a6c2effdc. Fixes ArcticaProject/nx-libs#775. | ||||
* | Regression fix for bfc05af7. Properly end lines in help/usage text. | Mike Gabriel | 2019-02-20 | 1 | -1/+1 |
| | | | | Fixes ArcticaProject/nx-libs#777. | ||||
* | nxproxy: list known session types in help output | Ulrich Sibiller | 2019-02-18 | 1 | -2/+5 |
| | | | | | | | | The old unix-* session types are deprecated and will always lead to a warning message "Unrecognized session type". Internally there are only three session types: agent, proxy and shadow, all the others are mapped to one of those three. | ||||
* | Fix parsing ports set to unix sockets | Vadim | 2019-01-22 | 1 | -1/+5 |
| | |||||
* | Make getUnixPath() return the right value when called without an argument. | Vadim | 2019-01-21 | 1 | -3/+3 |
| | | | | This fixes the verification in validateSpec() | ||||
* | Fix some memory leaks. | Mario Trangoni | 2018-07-03 | 1 | -0/+1 |
| | |||||
* | nxcomp: fix spelling errors as reported by codespell | Ulrich Sibiller | 2018-05-24 | 12 | -18/+18 |
| | |||||
* | nxcomp{,shad}/configure.ac: replace versionating non-portable sed construct ↵ | Mihai Moldovan | 2018-03-07 | 1 | -1/+1 |
| | | | | with hopefully more portable awk construct. | ||||
* | nxcomp{,shad}/configure.ac: pass more portable -E option to sed instead of -r. | Mihai Moldovan | 2018-03-02 | 1 | -1/+1 |
| | |||||
* | Fix clang error: comparison of array authCookie not equal to a null pointer ↵ | Mario Trangoni | 2018-03-01 | 1 | -1/+1 |
| | | | | is always true | ||||
* | nxagent: Also provide auto DPI feature via nx/nx option 'autodpi', taking ↵ | Mike Gabriel | 2018-02-27 | 2 | -1/+3 |
| | | | | only effect on session startups. | ||||
* | nxcomp/src/Loop.cpp: Harmonize log output. Uniformly, embrace port values by ↵ | Mike Gabriel | 2018-02-27 | 1 | -6/+6 |
| | | | | | | single quotes. Fixes ArcticaProject/nx-libs#617. | ||||
* | nxcomp/src/Loop.cpp: Make know the agent option 'keyconv' to nxcomp and ↵ | Mike Gabriel | 2018-02-27 | 1 | -1/+2 |
| | | | | | | tolerate it as a valid option. Fixes ArcticaProject/nx-libs#630. | ||||
* | nxagent: Add support for optionally enabling/disabling the magic pixel feature. | Mike Gabriel | 2018-02-26 | 2 | -1/+3 |
| | | | | Fixes ArcticaProject/nx-libs#657. | ||||
* | nxcomp{,shad}/configure.ac: trailing whitespace removal only. | Mihai Moldovan | 2018-02-25 | 1 | -1/+1 |
| | |||||
* | nxcomp/src/Loop.cpp: Typo fix in error msg. | Mike Gabriel | 2018-01-20 | 1 | -1/+1 |
| | |||||
* | nxcomp/src/Timestamp.{cpp,h}: use ::ctime_s or ::ctime_r instead of plain ↵ | Mihai Moldovan | 2018-01-09 | 2 | -22/+49 |
| | | | | | | ctime, on-stack buffers and return std::string objects. Fixes: ArcticaProject/nx-libs#616 | ||||
* | nxcomp/configure.ac: add check for ::ctime_s. | Mihai Moldovan | 2018-01-08 | 1 | -0/+17 |
| | |||||
* | EncodeBuffer.cpp: add another VALGRIND guard | Ulrich Sibiller | 2017-12-29 | 1 | -1/+9 |
| | | | | Fixes ArcticaProject/nx-libs#572 | ||||
* | nxcomp: drop strncpy in favour of snprintf | Ulrich Sibiller | 2017-12-29 | 3 | -44/+33 |
| | | | | with very few exceptions which require careful thinking ;-) | ||||
* | Loop.cpp: fix memleak happening with unknown tcp host | Ulrich Sibiller | 2017-12-29 | 1 | -0/+1 |
| | | | | | | | | | | | | | | | ==28424== 6 bytes in 1 blocks are definitely lost in loss record 1 of 7 ==28424== at 0x4C2DB8F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==28424== by 0x541D4D9: strndup (strndup.c:43) ==28424== by 0x4E8AD4B: ChannelEndPoint::getTCPHostAndPort(char**, long*) const (ChannelEndPoint.cpp:311) ==28424== by 0x4EBE9CC: ConnectToRemote(ChannelEndPoint&) (Loop.cpp:6656) ==28424== by 0x4EB0A4C: SetupProxyConnection() (Loop.cpp:3205) ==28424== by 0x4EDC81A: handleNegotiationInLoop(int&, fd_set&, fd_set&, timeval&) (Loop.cpp:14308) ==28424== by 0x4EAE40F: NXTransPrepare (Loop.cpp:2576) ==28424== by 0x4EAA801: NXTransContinue (Loop.cpp:1610) ==28424== by 0x4EB50C9: WaitCleanup() (Loop.cpp:4436) ==28424== by 0x4EA9507: NXTransProxy (Loop.cpp:1235) ==28424== by 0x400B2A: main (Main.c:111) | ||||
* | ChannelEndPoint.cpp: fix possible memleak in getUnixPath() | Ulrich Sibiller | 2017-12-29 | 3 | -4/+7 |
| | |||||
* | ChannelEndPoint.cpp: remove unneccessary code | Ulrich Sibiller | 2017-12-29 | 1 | -2/+0 |
| | | | | SAFE_FREE has set defaultUnixPath_ to NULL already | ||||
* | ChannelEndPoint.cpp: fix another memleak | Ulrich Sibiller | 2017-12-29 | 3 | -3/+7 |
| | | | | | | | | | | | | | | | ==7689== 50 bytes in 5 blocks are definitely lost in loss record 1 of 2 ==7689== at 0x4C2DB8F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==7689== by 0x54074D9: strndup (strndup.c:43) ==7689== by 0x4E7D803: ChannelEndPoint::getTCPHostAndPort(char**, long*) const (ChannelEndPoint.cpp:309) ==7689== by 0x4EC9D93: ConnectToRemote(ChannelEndPoint&) [clone .constprop.144] (Loop.cpp:6660) ==7689== by 0x4ECB94E: SetupProxyConnection() (Loop.cpp:3204) ==7689== by 0x4ECE824: handleNegotiationInLoop(int&, fd_set&, fd_set&, timeval&) [clone .isra.129] (Loop.cpp:14312) ==7689== by 0x4ED0F8A: NXTransPrepare (Loop.cpp:2575) ==7689== by 0x4ED1C35: NXTransContinue (Loop.cpp:1609) ==7689== by 0x4ED1D7B: WaitCleanup() (Loop.cpp:4440) ==7689== by 0x4ED2343: NXTransProxy (Loop.cpp:1234) ==7689== by 0x400B2A: main (Main.c:111) | ||||
* | EncodeBuffer.cpp: add VALGRIND guard | Ulrich Sibiller | 2017-12-29 | 1 | -0/+7 |
| | | | | | | | Same as in WriteBuffer.cpp Valgrind will complain about uninitialized data, but we are only writing to the memory here. | ||||
* | nxcomp: implement correct length handling for unix socket structs | Ulrich Sibiller | 2017-12-29 | 2 | -28/+57 |
| | | | | (partially) fixes ArcticaProject/nx-libs#612 | ||||
* | Loop.cpp: drop ugly ifdef indentation | Ulrich Sibiller | 2017-12-29 | 1 | -9/+6 |
| | |||||
* | Loop.cpp: create xServerAddrUNIX only if required | Ulrich Sibiller | 2017-12-29 | 1 | -4/+3 |
| | |||||
* | Loop.cpp: improve/fix usage of s(n)printf | Ulrich Sibiller | 2017-12-29 | 1 | -4/+6 |
| | |||||
* | Loop.cpp: some reformatting/simplification/FIXMEs | Ulrich Sibiller | 2017-12-29 | 1 | -5/+11 |
| | | | | (partially) fixes ArcticaProject/nx-libs#612 | ||||
* | Loop.cpp: delete passed object prior to overwriting it | Ulrich Sibiller | 2017-12-29 | 1 | -1/+4 |
| | |||||
* | ChannelEndPoint.cpp: re-scope/improve getSpec | Ulrich Sibiller | 2017-12-29 | 2 | -9/+21 |
| | |||||
* | Loop.cpp: delete structs when no longer required | Ulrich Sibiller | 2017-12-29 | 1 | -0/+2 |
| | | | | | | Fix another memleak (partially) fixes ArcticaProject/nx-libs#612 | ||||
* | Loop.cpp: always close testSocketFD | Ulrich Sibiller | 2017-12-29 | 1 | -1/+2 |
| | | | | | | was missing in the non-abstract code path (partially) fixes ArcticaProject/nx-libs#612 | ||||
* | Loop.cpp: free display before leaving SetupDisplaySocket() | Ulrich Sibiller | 2017-12-29 | 1 | -0/+5 |
| | | | | fixes a memory leak | ||||
* | Loop.cpp: Fix memset (size was 0) | Ulrich Sibiller | 2017-12-29 | 1 | -1/+1 |
| | | | | (partially) fixes ArcticaProject/nx-libs#612 | ||||
* | nxcomp/src/Log.h: take a reference-type in generic has_newline() function. | Mihai Moldovan | 2017-12-27 | 1 | -1/+1 |
| | | | | Should avoid copy-constructing objects again. | ||||
* | nxcomp/src/Log.cpp: don't confuse users with useless warning messages in ↵ | Mihai Moldovan | 2017-12-27 | 1 | -8/+12 |
| | | | | case that a log line append operation was requested, but the message level has lower precedence than the current log filter. | ||||
* | nxcomp/src/Log.h: make sure we don't pass NULL pointers to strstr(). | Mihai Moldovan | 2017-12-27 | 1 | -1/+8 |
| | |||||
* | nxcomp/src/Loop.cpp: whitespace in log messages only. | Mihai Moldovan | 2017-12-25 | 1 | -4/+4 |
| | |||||
* | nxcomp/src/Loop.cpp: use new log continuation mechanism. | Mihai Moldovan | 2017-12-25 | 1 | -18/+18 |
| | | | | | | | | | | | Especially don't flush data out mid-append. Doing so will lead to the next append operation failing. Should fix messages queuing up indefinitely (until they are discarded at program termination, at least) and missing messages in general. Fixes: ArcticaProject/nx-libs#577 Fixes: ArcticaProject/nx-libs#611 | ||||
* | nxcomp/src/Loop.cpp: whitespace only. | Mihai Moldovan | 2017-12-25 | 1 | -3/+3 |
| | |||||
* | nxcomp/src/Log.{cpp,h}: provide infrastructure for appending to already ↵ | Mihai Moldovan | 2017-12-25 | 2 | -23/+89 |
| | | | | | | | | | existing log lines. Also handle errors due to missing buffers gracefully. This error is surprisingly easy to trigger, so we should make sure that the program does not crash. | ||||
* | nxcomp/src/Log.h: NXLogStamp constructor should actually take a size_t-typed ↵ | Mihai Moldovan | 2017-12-25 | 1 | -1/+1 |
| | | | | line parameter. | ||||
* | nxcomp/src/Log.h: use initializer lists instead of initializing member ↵ | Mihai Moldovan | 2017-12-25 | 1 | -17/+4 |
| | | | | variables in-block. | ||||
* | nxcomp/src/ChannelEndPoint.cpp: don't use C-style casting in C++ code... | Mihai Moldovan | 2017-12-24 | 1 | -3/+3 |
| | |||||
* | nxcomp/src/Loop.cpp: fix small memory leak. | Mihai Moldovan | 2017-12-24 | 1 | -0/+2 |
| | |||||
* | nxcomp/src/Loop.cpp: log message fixups only. | Mihai Moldovan | 2017-12-18 | 1 | -2/+2 |
| | |||||
* | Support building with legacy zlib versions that do not ship a pkg-config file. | Mihai Moldovan | 2017-12-16 | 1 | -1/+1 |
| | |||||
* | nx{comp{,shad},proxy}: use dist-bzip2 instead of dist-xz. | Mihai Moldovan | 2017-12-16 | 1 | -1/+1 |
| | | | | | Automake older than version 1.11 does not support dist-xz. No workaround possible via a feature check, as far as I can tell. |