From 1af59b317d4e4120d6aa82dabe401a1f78a95168 Mon Sep 17 00:00:00 2001 From: Mike Gabriel Date: Sat, 23 Mar 2013 00:43:17 +0100 Subject: Add Jan's reasoning for using string_rep() instead of bash based string substitutions as comment to /debian/Makefile.replaces.sh. --- debian/Makefile.replace.sh | 24 ++++++++++++++++++++++++ debian/changelog | 7 +++++++ 2 files changed, 31 insertions(+) diff --git a/debian/Makefile.replace.sh b/debian/Makefile.replace.sh index d47d92bf4..83d6b5b3e 100644 --- a/debian/Makefile.replace.sh +++ b/debian/Makefile.replace.sh @@ -1,5 +1,29 @@ # from http://mywiki.wooledge.org/BashFAQ/021 +# The ${a/b/c} substitution is not POSIX compatible. Additionally, in +# bash 3.x, quotes do not escape slashes. This causes screwed up +# installation paths. +# +# SLES 11, bash-3.2-147.9.13 +# $ dirname="foo/bar" +# $ echo ${dirname//"foo/bar"/"omg/nei"} +# bar/omg/nei/bar +# +# openSUSE 12.2, bash-4.2-51.6.1 +# $ dirname="foo/bar" +# $ echo ${dirname//"foo/bar"/"omg/nei"} +# omg/nei +# +# openSUSE 12.2, dash-0.5.7-5.1.2.x86_64 +# $ dirname="foo/bar" +# $ echo ${dirname//"foo/bar"/"omg/nei"} +# dash: 2: Bad substitution +# +# Source this file into your bash scripts to make available +# a replacement (the string_rep function) for this substitution +# mess. +# + string_rep() { # initialize vars diff --git a/debian/changelog b/debian/changelog index d8f43823b..5fb1d345e 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,10 @@ +nx-libs (2:3.5.0.19-0) UNRELEASED; urgency=low + + * Add Jan's reasoning for using string_rep() instead of bash based + string substitutions as comment to /debian/Makefile.replaces.sh. + + -- Mike Gabriel Sat, 23 Mar 2013 00:42:01 +0100 + nx-libs (2:3.5.0.18-0) unstable; urgency=low [ Mike Gabriel ] -- cgit v1.2.3