From ffba3aab3f2cf140403b19e23756008f9c947091 Mon Sep 17 00:00:00 2001 From: Mario Trangoni Date: Fri, 5 Feb 2021 18:29:43 +0100 Subject: shellcheck: Fix SC2164 issues For more information: https://www.shellcheck.net/wiki/SC2164 -- Use 'cd ... || exit' or 'cd ... |... Signed-off-by: Mario Trangoni --- regenerate-symbol-docs.sh | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/regenerate-symbol-docs.sh b/regenerate-symbol-docs.sh index 05548bdb0..90bc9da34 100755 --- a/regenerate-symbol-docs.sh +++ b/regenerate-symbol-docs.sh @@ -23,7 +23,7 @@ SYMBOLS_FILE="doc/libNX_X11/symbols/libNX_X11::symbols.txt" DOC_FILE="doc/libNX_X11/symbols/libNX_X11::symbol-usage_internally.txt" echo "Scanning for libNX_X11 symbols: in libNX_X11 internally: $DOC_FILE" -cd nx-X11/lib/X11/ +cd nx-X11/lib/X11/ || exit grep -v -E "^#" "../../../$SYMBOLS_FILE" | while read -r symbol; do echo @@ -31,11 +31,11 @@ grep -v -E "^#" "../../../$SYMBOLS_FILE" | while read -r symbol; do grep -n "$symbol" *.{c,h} 2>/dev/null done > "../../../$DOC_FILE" -cd - 1>/dev/null +cd - 1>/dev/null || exit DOC_FILE="doc/libNX_X11/symbols/libNX_X11::symbol-usage_nxagent.txt" echo "Scanning for libNX_X11 symbols: in hw/nxagent: $DOC_FILE" -cd nx-X11/programs/Xserver/hw/nxagent/ +cd nx-X11/programs/Xserver/hw/nxagent/ || exit grep -v -E "^#" "../../../../../$SYMBOLS_FILE" | while read -r symbol; do echo @@ -43,11 +43,11 @@ grep -v -E "^#" "../../../../../$SYMBOLS_FILE" | while read -r symbol; do grep -n "$symbol" *.{c,h} 2>/dev/null done > "../../../../../$DOC_FILE" -cd - 1>/dev/null +cd - 1>/dev/null || exit DOC_FILE="doc/libNX_X11/symbols/libNX_X11::symbol-usage_nxcompext.txt" echo "Scanning for libNX_X11 symbols: in hw/nxagent/compext: $DOC_FILE" -cd nx-X11/programs/Xserver/hw/nxagent/compext/ +cd nx-X11/programs/Xserver/hw/nxagent/compext/ || exit grep -v -E "^#" "../../../../../../$SYMBOLS_FILE" | while read -r symbol; do echo @@ -55,7 +55,7 @@ grep -v -E "^#" "../../../../../../$SYMBOLS_FILE" | while read -r symbol; do grep -n "$symbol" *.{c,h} 2>/dev/null done > "../../../../../../$DOC_FILE" -cd - 1>/dev/null +cd - 1>/dev/null || exit # nxcompext @@ -64,7 +64,7 @@ SYMBOLS_FILE="doc/nxcompext/symbols/nxcompext::symbols.txt" DOC_FILE="doc/nxcompext/symbols/nxcompext::symbol-usage_internally.txt" echo "Scanning for nxcompext symbols: in hw/nxagent/compext internally: $DOC_FILE" -cd nx-X11/programs/Xserver/hw/nxagent/compext/ +cd nx-X11/programs/Xserver/hw/nxagent/compext/ || exit grep -v -E "^#" "../../../../../../$SYMBOLS_FILE" | while read -r symbol; do echo @@ -72,11 +72,11 @@ grep -v -E "^#" "../../../../../../$SYMBOLS_FILE" | while read -r symbol; do grep -n "$symbol" *.{c,h} 2>/dev/null done > "../../../../../../$DOC_FILE" -cd - 1>/dev/null +cd - 1>/dev/null || exit DOC_FILE="doc/nxcompext/symbols/nxcompext::symbol-usage_nxagent.txt" echo "Scanning for nxcompext symbols: in hw/nxagent: $DOC_FILE" -cd nx-X11/programs/Xserver/hw/nxagent/ +cd nx-X11/programs/Xserver/hw/nxagent/ || exit grep -v -E "^#" "../../../../../$SYMBOLS_FILE" | while read -r symbol; do echo @@ -84,4 +84,4 @@ grep -v -E "^#" "../../../../../$SYMBOLS_FILE" | while read -r symbol; do grep -n "$symbol" *.{c,h} 2>/dev/null done > "../../../../../$DOC_FILE" -cd - 1>/dev/null +cd - 1>/dev/null || exit -- cgit v1.2.3 From dfee5a9886112b29f14f762016c8fe892846bfef Mon Sep 17 00:00:00 2001 From: Mario Trangoni Date: Sat, 6 Feb 2021 17:56:53 +0100 Subject: shellcheck: Fix SC2064 issues For more information: https://www.shellcheck.net/wiki/SC2064 -- Use single quotes, otherwise this... Signed-off-by: Mario Trangoni --- roll-tarballs.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/roll-tarballs.sh b/roll-tarballs.sh index c9af13102..95b820c5a 100755 --- a/roll-tarballs.sh +++ b/roll-tarballs.sh @@ -68,7 +68,7 @@ TARGETDIR="../.." MANIFEST="$(mktemp)" TEMP_DIR="$(mktemp -d)" -trap "rm -f \"${MANIFEST}\"; rm -rf \"${TEMP_DIR}\"" 0 +trap 'rm -f "${MANIFEST}"; rm -rf "${TEMP_DIR}"' 0 # create local copy of Git project at temp location git archive --format=tar "${CHECKOUT}" --prefix="${PROJECT}-${RELEASE}/" | ( cd "$TEMP_DIR"; tar xf - ) -- cgit v1.2.3 From 71ae04011c353b0341b5ab0c16dad12ebefe6a67 Mon Sep 17 00:00:00 2001 From: Mario Trangoni Date: Sat, 6 Feb 2021 17:58:47 +0100 Subject: shellcheck: Fix SC2022 issue $ find . -name "*.sh" | xargs shellcheck -i SC2022 In ./roll-tarballs.sh line 120: ls -d nx-X11/extras/* | grep -v "nx-X11/extras/tmpMesa*" | xargs rm -r ^----------------------^ SC2022: Note that unlike globs, a* here matches 'aaa' but not 'alpha'. For more information: https://www.shellcheck.net/wiki/SC2022 -- Note that unlike globs, a* here m... Signed-off-by: Mario Trangoni --- roll-tarballs.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/roll-tarballs.sh b/roll-tarballs.sh index 95b820c5a..a263c7218 100755 --- a/roll-tarballs.sh +++ b/roll-tarballs.sh @@ -117,7 +117,7 @@ if [ "x$MODE" = "xfull" ]; then # nx-X11/extras/Mesa. Deal with the Mesa.patches symlink/folder accordingly cp -Lr "nx-X11/extras/Mesa" "nx-X11/extras/tmpMesa" cp -Lr "nx-X11/extras/Mesa.patches" "nx-X11/extras/tmpMesa.patches" - ls -d nx-X11/extras/* | grep -v "nx-X11/extras/tmpMesa*" | xargs rm -r + ls -d nx-X11/extras/* | grep -v "^nx-X11/extras/tmpMesa*" | xargs rm -r mv "nx-X11/extras/tmpMesa" "nx-X11/extras/Mesa" mv "nx-X11/extras/tmpMesa.patches" "nx-X11/extras/Mesa.patches" -- cgit v1.2.3 From 6bada8f63d98128b269fb379194aead1eacbd711 Mon Sep 17 00:00:00 2001 From: Mike Gabriel Date: Mon, 7 Jun 2021 14:32:08 +0200 Subject: shellcheck: Fix SC2230 issue ./nx-X11/x-indent.sh line 5: INDENT=$(which gnuindent || which gindent || which indent) ^---^ SC2230: which is non-standard. Use builtin 'command -v' instead. ^---^ SC2230: which is non-standard. Use builtin 'command -v' instead. ^---^ SC2230: which is non-standard. Use builtin 'command -v' instead. For more information: https://www.shellcheck.net/wiki/SC2230 -- which is non-standard. Use builti... Signed-off-by: Mike Gabriel --- nx-X11/x-indent.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nx-X11/x-indent.sh b/nx-X11/x-indent.sh index 327aa6a4f..4690372e6 100755 --- a/nx-X11/x-indent.sh +++ b/nx-X11/x-indent.sh @@ -2,7 +2,7 @@ # We want GNU indent, so first search for gindent to avoid /usr/bin/indent # on the BSDs, which won't work for us -INDENT=$(which gnuindent || which gindent || which indent) +INDENT=$(command -v gnuindent || command -v gindent || command -v indent) if [ -z "${INDENT}" ] ; then echo "Could not find indent, sorry..." >&2 -- cgit v1.2.3