From 50eb5e4a9bf812895a7d5c4e6ae0775c6910931f Mon Sep 17 00:00:00 2001 From: Ulrich Sibiller Date: Thu, 20 Oct 2016 00:15:20 +0200 Subject: sendexev.c: Fix return of unitialized variable Well, kinda fix. Upstream handles that differently here, we need a thorough check! Add another FIXME comment because of this. --- nx-X11/programs/Xserver/Xi/sendexev.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) (limited to 'nx-X11/programs/Xserver/Xi/sendexev.c') diff --git a/nx-X11/programs/Xserver/Xi/sendexev.c b/nx-X11/programs/Xserver/Xi/sendexev.c index 28286d97f..a851c5120 100644 --- a/nx-X11/programs/Xserver/Xi/sendexev.c +++ b/nx-X11/programs/Xserver/Xi/sendexev.c @@ -149,10 +149,14 @@ ProcXSendExtensionEvent (client) return Success; } - // FIXME: ret is not initialized and should not be returned... - + /* + the previous code here returned the unitialized variable ret, + so using Success we have defined returncode at least. FIXME: + Upstream works different here, we must check this! + */ if (stuff->num_events == 0) - return ret; + /* return ret; */ + return Success; /* The client's event type must be one defined by an extension. */ -- cgit v1.2.3