From 586742b715a3e3451a4587439778c410a1970cdd Mon Sep 17 00:00:00 2001
From: Ulrich Sibiller <uli42@gmx.de>
Date: Fri, 15 Feb 2019 09:37:18 +0100
Subject: Revert "nxagent: rework Bool handling"

This reverts commit 16cd2bbe1c4425e3fa557f9ca0723aa94a50b071.

It turned out that I had missed some of the Booleans being actually
tristate variables. I think I can fix this (they do not need to be
tristate) but I revert this for now to get back to a working state
(there are reports about non-working fullscreen mode and reconnect
problems).

Refers to ArcticaProject/nx-libs#772
---
 nx-X11/programs/Xserver/hw/nxagent/Args.c | 32 +++++++++++++++----------------
 1 file changed, 16 insertions(+), 16 deletions(-)

(limited to 'nx-X11/programs/Xserver/hw/nxagent/Args.c')

diff --git a/nx-X11/programs/Xserver/hw/nxagent/Args.c b/nx-X11/programs/Xserver/hw/nxagent/Args.c
index 57bcfa425..949892f25 100644
--- a/nx-X11/programs/Xserver/hw/nxagent/Args.c
+++ b/nx-X11/programs/Xserver/hw/nxagent/Args.c
@@ -522,7 +522,7 @@ int ddxProcessArgument(int argc, char *argv[], int i)
             sscanf(argv[i], "%i", &level) == 1 &&
                 level >= 0 && level <= 2)
     {
-      if (!nxagentOption(Shadow))
+      if (nxagentOption(Shadow) == 0)
       {
         nxagentChangeOption(DeferLevel, level);
 
@@ -624,7 +624,7 @@ int ddxProcessArgument(int argc, char *argv[], int i)
         }
       }
 
-      if (nxagentUserGeometry.flag || nxagentOption(Fullscreen)) return 2;
+      if (nxagentUserGeometry.flag || (nxagentOption(Fullscreen) == 1)) return 2;
     }
 
     return 0;
@@ -1122,7 +1122,7 @@ static void nxagentParseSingleOption(char *name, char *value)
   }
   else if (!strcmp(name, "render"))
   {
-    if (nxagentReconnectTrap)
+    if (nxagentReconnectTrap == True)
     {
       #ifdef DEBUG
       fprintf(stderr, "nxagentParseSingleOption: Ignoring option 'render' at reconnection.\n");
@@ -1154,7 +1154,7 @@ static void nxagentParseSingleOption(char *name, char *value)
   }
   else if (!strcmp(name, "fullscreen"))
   {
-    if (nxagentReconnectTrap)
+    if (nxagentReconnectTrap == True)
     {
       #ifdef DEBUG
       fprintf(stderr, "nxagentParseSingleOption: Ignoring option 'fullscreen' at reconnection.\n");
@@ -1267,13 +1267,13 @@ static void nxagentParseSingleOption(char *name, char *value)
   }
   else if (!strcmp(name, "resize"))
   {
-    if (!nxagentOption(DesktopResize) || strcmp(value, "0") == 0)
+    if (nxagentOption(DesktopResize) == 0 || strcmp(value, "0") == 0)
     {
-      nxagentResizeDesktopAtStartup = False;
+      nxagentResizeDesktopAtStartup = 0;
     }
     else if (strcmp(value, "1") == 0)
     {
-      nxagentResizeDesktopAtStartup = True;
+      nxagentResizeDesktopAtStartup = 1;
     }
     else
     {
@@ -1324,7 +1324,7 @@ static void nxagentParseSingleOption(char *name, char *value)
   }
   else if (!strcmp(name, "autodpi"))
   {
-    if (nxagentReconnectTrap)
+    if (nxagentReconnectTrap == True)
     {
       #ifdef DEBUG
       fprintf(stderr, "nxagentParseSingleOption: Ignoring option 'autodpi' at reconnection.\n");
@@ -1793,7 +1793,7 @@ N/A
 
     #endif
 
-    if (nxagentOption(Rootless) && nxagentOption(Fullscreen))
+    if ((nxagentOption(Rootless) == 1) && nxagentOption(Fullscreen) == 1)
     {
       #ifdef TEST
       fprintf(stderr, "WARNING: Ignoring fullscreen option for rootless session.\n");
@@ -2092,7 +2092,7 @@ FIXME: In rootless mode the backing-store support is not functional yet.
       nxagentAlphaEnabled = False;
     }
 
-    if (nxagentOption(Rootless) && nxagentOption(Xdmcp))
+    if ((nxagentOption(Rootless) == 1) && nxagentOption(Xdmcp))
     {
       FatalError("PANIC! Cannot start a XDMCP session in rootless mode.\n");
     }
@@ -2102,7 +2102,7 @@ FIXME: In rootless mode the backing-store support is not functional yet.
      * XDMCP sessions.
      */
 
-    if (nxagentOption(Reset) && nxagentMaxAllowedResets == 0)
+    if (nxagentOption(Reset) == True && nxagentMaxAllowedResets == 0)
     {
       #ifdef WARNING
       fprintf(stderr, "nxagentPostProcessArgs: Disabling the server reset.\n");
@@ -2119,7 +2119,7 @@ FIXME: In rootless mode the backing-store support is not functional yet.
      * to a standard XFree86 server.
      */
 
-    if (!nxagentOption(Reset))
+    if (nxagentOption(Reset) == False)
     {
       #ifdef TEST
       fprintf(stderr, "nxagentPostProcessArgs: Disabling dispatch of exception at server reset.\n");
@@ -2399,7 +2399,7 @@ void nxagentSetDeferLevel(void)
    * of the agent.
    */
 
-  if (nxagentOption(Streaming))
+  if (nxagentOption(Streaming) == 1)
   {
     fprintf(stderr, "Warning: Streaming of images not available in this agent.\n");
 
@@ -2484,7 +2484,7 @@ void nxagentSetDeferLevel(void)
    * Set the defer timeout.
    */
 
-  if (nxagentOption(Shadow))
+  if (nxagentOption(Shadow) == 1)
   {
     #ifdef TEST
     fprintf(stderr, "nxagentSetDeferLevel: Ignoring defer timeout parameter in shadow mode.\n");
@@ -2499,7 +2499,7 @@ void nxagentSetDeferLevel(void)
    * Set the defer level.
    */
 
-  if (nxagentOption(Shadow) )
+  if (nxagentOption(Shadow) == 1)
   {
     #ifdef TEST
     fprintf(stderr, "nxagentSetDeferLevel: Ignoring defer parameter in shadow mode.\n");
@@ -2631,7 +2631,7 @@ void nxagentSetScheduler(void)
    * The smart scheduler is the default.
    */
 
-  if (nxagentOption(Shadow))
+  if (nxagentOption(Shadow) == 1)
   {
     #ifdef TEST
     fprintf(stderr, "nxagentSetScheduler: Using the dumb scheduler in shadow mode.\n");
-- 
cgit v1.2.3