diff options
author | Olivier Fourdan <ofourdan@redhat.com> | 2015-01-16 20:08:59 +0100 |
---|---|---|
committer | Mike DePaulo <mikedep333@gmail.com> | 2015-03-28 08:36:28 -0400 |
commit | 5772845bf986119eca2421ecae0ab16f9df917e7 (patch) | |
tree | 3ef6a9e22f68ddec083e22fafaa59c6d8c08af16 /apps | |
parent | 05f00e318b7842595179ad4d228dfaee5e992951 (diff) | |
download | vcxsrv-5772845bf986119eca2421ecae0ab16f9df917e7.tar.gz vcxsrv-5772845bf986119eca2421ecae0ab16f9df917e7.tar.bz2 vcxsrv-5772845bf986119eca2421ecae0ab16f9df917e7.zip |
xkb: Don't swap XkbSetGeometry data in the input buffer
The XkbSetGeometry request embeds data which needs to be swapped when the
server and the client have different endianess.
_XkbSetGeometry() invokes functions that swap these data directly in the
input buffer.
However, ProcXkbSetGeometry() may call _XkbSetGeometry() more than once
(if there is more than one keyboard), thus causing on swapped clients the
same data to be swapped twice in memory, further causing a server crash
because the strings lengths on the second time are way off bounds.
To allow _XkbSetGeometry() to run reliably more than once with swapped
clients, do not swap the data in the buffer, use variables instead.
Signed-off-by: Olivier Fourdan <ofourdan@redhat.com>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
(cherry picked from commit 81c90dc8f0aae3b65730409b1b615b5fa7280ebd)
(cherry picked from commit 29be310c303914090298ddda93a5bd5d00a94945)
Signed-off-by: Julien Cristau <jcristau@debian.org>
Diffstat (limited to 'apps')
0 files changed, 0 insertions, 0 deletions