libxext libx11 libxcb libXinerama libXau pixman xserver git update 18/10/2010

3 files changed, 55 insertions, 64 deletions

diff --git a/xorg-server/dix/devices.c b/xorg-server/dix/devices.c
index 42ea9c8d8..ec43f294a 100644
--- a/xorg-server/dix/devices.c
+++ b/xorg-server/dix/devices.c
@@ -2111,9 +2111,6 @@ ProcChangePointerControl(ClientPtr client)
     REQUEST(xChangePointerControlReq);

     REQUEST_SIZE_MATCH(xChangePointerControlReq);

 

-    if (!mouse->ptrfeed->CtrlProc)

-        return BadDevice;

-

     ctrl = mouse->ptrfeed->ctrl;

     if ((stuff->doAccel != xTrue) && (stuff->doAccel != xFalse)) {

 	client->errorValue = stuff->doAccel;

@@ -2161,7 +2158,7 @@ ProcChangePointerControl(ClientPtr client)
 

     for (dev = inputInfo.devices; dev; dev = dev->next) {

         if ((dev == mouse || (!IsMaster(dev) && dev->u.master == mouse)) &&

-            dev->ptrfeed && dev->ptrfeed->CtrlProc) {

+            dev->ptrfeed) {

 	    rc = XaceHook(XACE_DEVICE_ACCESS, client, dev, DixManageAccess);

 	    if (rc != Success)

 		return rc;

@@ -2170,9 +2167,8 @@ ProcChangePointerControl(ClientPtr client)
 

     for (dev = inputInfo.devices; dev; dev = dev->next) {

         if ((dev == mouse || (!IsMaster(dev) && dev->u.master == mouse)) &&

-            dev->ptrfeed && dev->ptrfeed->CtrlProc) {

+            dev->ptrfeed) {

             dev->ptrfeed->ctrl = ctrl;

-            (*dev->ptrfeed->CtrlProc)(dev, &mouse->ptrfeed->ctrl);

         }

     }

 

diff --git a/xorg-server/dix/dixfonts.c b/xorg-server/dix/dixfonts.c
index 1c9da1e26..dc4b32cc2 100644
--- a/xorg-server/dix/dixfonts.c
+++ b/xorg-server/dix/dixfonts.c
@@ -321,10 +321,10 @@ doOpenFont(ClientPtr client, OFclosurePtr c)
 	    continue;

 	}

 	if (err == Suspended) {

-	    if (!c->slept) {

-		c->slept = TRUE;

-		ClientSleep(client, (ClientSleepProcPtr)doOpenFont, (pointer) c);

-	    }

+	    if (!ClientIsAsleep(client))

+		ClientSleep(client, (ClientSleepProcPtr)doOpenFont, c);

+	    else

+		goto xinerama_sleep;

 	    return TRUE;

 	}

 	break;

@@ -373,8 +373,8 @@ bail:
 	SendErrorToClient(c->client, X_OpenFont, 0,

 			  c->fontid, FontToXError(err));

     }

-    if (c->slept)

-	ClientWakeup(c->client);

+    ClientWakeup(c->client);

+xinerama_sleep:

     for (i = 0; i < c->num_fpes; i++) {

 	FreeFPE(c->fpe_list[i]);

     }

@@ -460,7 +460,6 @@ OpenFont(ClientPtr client, XID fid, Mask flags, unsigned lenfname, char *pfontna
     c->current_fpe = 0;

     c->num_fpes = num_fpes;

     c->fnamelen = lenfname;

-    c->slept = FALSE;

     c->flags = flags;

     c->non_cachable_font = cached;

 

@@ -622,12 +621,12 @@ doListFontsAndAliases(ClientPtr client, LFclosurePtr c)
 		 c->names);

 

 	    if (err == Suspended) {

-		if (!c->slept) {

-		    c->slept = TRUE;

+		if (!ClientIsAsleep(client))

 		    ClientSleep(client,

-			(ClientSleepProcPtr)doListFontsAndAliases,

-			(pointer) c);

-		}

+				(ClientSleepProcPtr)doListFontsAndAliases,

+				c);

+		else

+		    goto xinerama_sleep;

 		return TRUE;

 	    }

 

@@ -650,12 +649,12 @@ doListFontsAndAliases(ClientPtr client, LFclosurePtr c)
 		     c->current.patlen, c->current.max_names - c->names->nnames,

 		     &c->current.private);

 		if (err == Suspended) {

-		    if (!c->slept) {

+		    if (!ClientIsAsleep(client))

 			ClientSleep(client,

 				    (ClientSleepProcPtr)doListFontsAndAliases,

-				    (pointer) c);

-			c->slept = TRUE;

-		    }

+				    c);

+		    else

+			goto xinerama_sleep;

 		    return TRUE;

 		}

 		if (err == Successful)

@@ -668,12 +667,12 @@ doListFontsAndAliases(ClientPtr client, LFclosurePtr c)
 		    ((pointer) c->client, fpe, &name, &namelen, &tmpname,

 		     &resolvedlen, c->current.private);

 		if (err == Suspended) {

-		    if (!c->slept) {

+		    if (ClientIsAsleep(client))

 			ClientSleep(client,

 				    (ClientSleepProcPtr)doListFontsAndAliases,

-				    (pointer) c);

-			c->slept = TRUE;

-		    }

+				    c);

+		    else

+			goto xinerama_sleep;

 		    return TRUE;

 		}

 		if (err == FontNameAlias) {

@@ -822,8 +821,8 @@ finish:
     free(bufferStart);

 

 bail:

-    if (c->slept)

-	ClientWakeup(client);

+    ClientWakeup(client);

+xinerama_sleep:

     for (i = 0; i < c->num_fpes; i++)

 	FreeFPE(c->fpe_list[i]);

     free(c->fpe_list);

@@ -881,7 +880,6 @@ ListFonts(ClientPtr client, unsigned char *pattern, unsigned length,
     c->current.list_started = FALSE;

     c->current.private = 0;

     c->haveSaved = FALSE;

-    c->slept = FALSE;

     c->savedName = 0;

     doListFontsAndAliases(client, c);

     return Success;

@@ -928,11 +926,11 @@ doListFontsWithInfo(ClientPtr client, LFWIclosurePtr c)
 		 c->current.max_names, &c->current.private);

 	    if (err == Suspended)

  	    {

-		if (!c->slept)

- 		{

-		    ClientSleep(client, (ClientSleepProcPtr)doListFontsWithInfo, c);

-		    c->slept = TRUE;

-		}

+		if (!ClientIsAsleep(client))

+		    ClientSleep(client,

+				(ClientSleepProcPtr)doListFontsWithInfo, c);

+		else

+		    goto xinerama_sleep;

 		return TRUE;

 	    }

 	    if (err == Successful)

@@ -947,13 +945,11 @@ doListFontsWithInfo(ClientPtr client, LFWIclosurePtr c)
 		 &numFonts, c->current.private);

 	    if (err == Suspended)

  	    {

-		if (!c->slept)

- 		{

+		if (!ClientIsAsleep(client))

 		    ClientSleep(client,

-		    	     (ClientSleepProcPtr)doListFontsWithInfo,

-			     c);

-		    c->slept = TRUE;

-		}

+				(ClientSleepProcPtr)doListFontsWithInfo, c);

+		else

+		    goto xinerama_sleep;

 		return TRUE;

 	    }

 	}

@@ -1098,8 +1094,8 @@ finish:
 		     - sizeof(xGenericReply));

     WriteSwappedDataToClient(client, length, &finalReply);

 bail:

-    if (c->slept)

-	ClientWakeup(client);

+    ClientWakeup(client);

+xinerama_sleep:

     for (i = 0; i < c->num_fpes; i++)

 	FreeFPE(c->fpe_list[i]);

     free(c->reply);

@@ -1154,7 +1150,6 @@ StartListFontsWithInfo(ClientPtr client, int length, unsigned char *pattern,
     c->current.private = 0;

     c->savedNumFonts = 0;

     c->haveSaved = FALSE;

-    c->slept = FALSE;

     c->savedName = 0;

     doListFontsWithInfo(client, c);

     return Success;

@@ -1181,7 +1176,7 @@ doPolyText(ClientPtr client, PTclosurePtr c)
 	fpe = c->pGC->font->fpe;

 	(*fpe_functions[fpe->type].client_died) ((pointer) client, fpe);

 

-	if (c->slept)

+	if (ClientIsAsleep(client))

 	{

 	    /* Client has died, but we cannot bail out right now.  We

 	       need to clean up after the work we did when going to

@@ -1198,7 +1193,7 @@ doPolyText(ClientPtr client, PTclosurePtr c)
     }

 

     /* Make sure our drawable hasn't disappeared while we slept. */

-    if (c->slept && c->pDraw)

+    if (ClientIsAsleep(client) && c->pDraw)

     {

 	DrawablePtr pDraw;

 	dixLookupDrawable(&pDraw, c->did, client, 0, DixWriteAccess);

@@ -1212,7 +1207,7 @@ doPolyText(ClientPtr client, PTclosurePtr c)
 	}

     }

 

-    client_state = c->slept ? SLEEPING : NEVER_SLEPT;

+    client_state = ClientIsAsleep(client) ? SLEEPING : NEVER_SLEPT;

 

     while (c->endReq - c->pElt > TextEltHeader)

     {

@@ -1295,7 +1290,7 @@ doPolyText(ClientPtr client, PTclosurePtr c)
 

 	    if (lgerr == Suspended)

 	    {

-		if (!c->slept) {

+		if (!ClientIsAsleep(client)) {

 		    int len;

 		    GC *pGC;

 		    PTclosurePtr new_closure;

@@ -1368,15 +1363,14 @@ doPolyText(ClientPtr client, PTclosurePtr c)
 		    c->pGC = pGC;

 		    ValidateGC(c->pDraw, c->pGC);

 		    

-		    c->slept = TRUE;

-		    ClientSleep(client,

-		    	     (ClientSleepProcPtr)doPolyText,

-			     (pointer) c);

+		    ClientSleep(client, (ClientSleepProcPtr)doPolyText, c);

 

 		    /* Set up to perform steps 3 and 4 */

 		    client_state = START_SLEEP;

 		    continue;	/* on to steps 3 and 4 */

 		}

+		else

+		    goto xinerama_sleep;

 		return TRUE;

 	    }

 	    else if (lgerr != Successful)

@@ -1419,9 +1413,10 @@ bail:
 #endif

 	    SendErrorToClient(c->client, c->reqType, 0, 0, err);

     }

-    if (c->slept)

+    if (ClientIsAsleep(client))

     {

 	ClientWakeup(c->client);

+xinerama_sleep:

 	ChangeGC(NullClient, c->pGC, clearGCmask, clearGC);

 

 	/* Unreference the font from the scratch GC */

@@ -1460,7 +1455,6 @@ PolyText(ClientPtr client, DrawablePtr pDraw, GC *pGC, unsigned char *pElt,
     local_closure.pGC = pGC;

     local_closure.did = did;

     local_closure.err = Success;

-    local_closure.slept = FALSE;

 

     (void) doPolyText(client, &local_closure);

     return Success;

@@ -1485,7 +1479,7 @@ doImageText(ClientPtr client, ITclosurePtr c)
     }

 

     /* Make sure our drawable hasn't disappeared while we slept. */

-    if (c->slept && c->pDraw)

+    if (ClientIsAsleep(client) && c->pDraw)

     {

 	DrawablePtr pDraw;

 	dixLookupDrawable(&pDraw, c->did, client, 0, DixWriteAccess);

@@ -1502,7 +1496,7 @@ doImageText(ClientPtr client, ITclosurePtr c)
     lgerr = LoadGlyphs(client, c->pGC->font, c->nChars, c->itemSize, c->data);

     if (lgerr == Suspended)

     {

-        if (!c->slept) {

+        if (!ClientIsAsleep(client)) {

 	    GC *pGC;

 	    unsigned char *data;

 	    ITclosurePtr new_closure;

@@ -1555,9 +1549,10 @@ doImageText(ClientPtr client, ITclosurePtr c)
 	    c->pGC = pGC;

 	    ValidateGC(c->pDraw, c->pGC);

 

-	    c->slept = TRUE;

-            ClientSleep(client, (ClientSleepProcPtr)doImageText, (pointer) c);

+            ClientSleep(client, (ClientSleepProcPtr)doImageText, c);

         }

+	else

+	    goto xinerama_sleep;

         return TRUE;

     }

     else if (lgerr != Successful)

@@ -1576,9 +1571,10 @@ bail:
     if (err != Success && c->client != serverClient) {

 	SendErrorToClient(c->client, c->reqType, 0, 0, err);

     }

-    if (c->slept)

+    if (ClientIsAsleep(client))

     {

 	ClientWakeup(c->client);

+xinerama_sleep:

 	ChangeGC(NullClient, c->pGC, clearGCmask, clearGC);

 

 	/* Unreference the font from the scratch GC */

@@ -1616,7 +1612,6 @@ ImageText(ClientPtr client, DrawablePtr pDraw, GC *pGC, int nChars,
 	local_closure.itemSize = 2;

     }

     local_closure.did = did;

-    local_closure.slept = FALSE;

 

     (void) doImageText(client, &local_closure);

     return Success;

diff --git a/xorg-server/dix/getevents.c b/xorg-server/dix/getevents.c
index 3885cd771..559b20b55 100644
--- a/xorg-server/dix/getevents.c
+++ b/xorg-server/dix/getevents.c
@@ -652,8 +652,8 @@ clipValuators(DeviceIntPtr pDev, int first_valuator, int num_valuators,
  *        events if a DCCE was generated.

  * @return The updated @events pointer.

  */

-static EventListPtr

-updateFromMaster(EventListPtr events, DeviceIntPtr dev, int type, int *num_events)

+EventListPtr

+UpdateFromMaster(EventListPtr events, DeviceIntPtr dev, int type, int *num_events)

 {

     DeviceIntPtr master;

 

@@ -929,7 +929,7 @@ GetKeyboardValuatorEvents(EventList *events, DeviceIntPtr pDev, int type,
 

     num_events = 1;

 

-    events = updateFromMaster(events, pDev, DEVCHANGE_KEYBOARD_EVENT, &num_events);

+    events = UpdateFromMaster(events, pDev, DEVCHANGE_KEYBOARD_EVENT, &num_events);

 

     /* Handle core repeating, via press/release/press/release. */

     if (type == KeyPress && key_is_down(pDev, key_code, KEY_POSTED)) {

@@ -1091,7 +1091,7 @@ GetPointerEvents(EventList *events, DeviceIntPtr pDev, int type, int buttons,
         (type == MotionNotify && num_valuators <= 0))

         return 0;

 

-    events = updateFromMaster(events, pDev, DEVCHANGE_POINTER_EVENT, &num_events);

+    events = UpdateFromMaster(events, pDev, DEVCHANGE_POINTER_EVENT, &num_events);

 

     raw = (RawDeviceEvent*)events->event;

     events++;

@@ -1206,7 +1206,7 @@ GetProximityEvents(EventList *events, DeviceIntPtr pDev, int type,
         (num_valuators + first_valuator) > pDev->valuator->numAxes)

         return 0;

 

-    events = updateFromMaster(events, pDev, DEVCHANGE_POINTER_EVENT, &num_events);

+    events = UpdateFromMaster(events, pDev, DEVCHANGE_POINTER_EVENT, &num_events);

 

     event = (DeviceEvent *) events->event;

     init_event(pDev, event, GetTimeInMillis());