diff options
| author | Olivier Fourdan <ofourdan@redhat.com> | 2015-01-16 20:08:59 +0100 |
|---|---|---|
| committer | Mike DePaulo <mikedep333@gmail.com> | 2015-02-20 06:37:02 -0500 |
| commit | ef3dd96ef2c8971c050ddd24ad8ca2d2ec7757bc (patch) | |
| tree | f4022a7f598d79fec0f66f2c375497adfe2f2f77 /xorg-server/hw/xnest/Keyboard.c | |
| parent | 7e45dd4fd9998865a92ff2f9bc4e2e125da704da (diff) | |
| download | vcxsrv-ef3dd96ef2c8971c050ddd24ad8ca2d2ec7757bc.tar.gz vcxsrv-ef3dd96ef2c8971c050ddd24ad8ca2d2ec7757bc.tar.bz2 vcxsrv-ef3dd96ef2c8971c050ddd24ad8ca2d2ec7757bc.zip | |
xkb: Don't swap XkbSetGeometry data in the input buffer
The XkbSetGeometry request embeds data which needs to be swapped when the
server and the client have different endianess.
_XkbSetGeometry() invokes functions that swap these data directly in the
input buffer.
However, ProcXkbSetGeometry() may call _XkbSetGeometry() more than once
(if there is more than one keyboard), thus causing on swapped clients the
same data to be swapped twice in memory, further causing a server crash
because the strings lengths on the second time are way off bounds.
To allow _XkbSetGeometry() to run reliably more than once with swapped
clients, do not swap the data in the buffer, use variables instead.
Signed-off-by: Olivier Fourdan <ofourdan@redhat.com>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
(cherry picked from commit 81c90dc8f0aae3b65730409b1b615b5fa7280ebd)
(cherry picked from commit 29be310c303914090298ddda93a5bd5d00a94945)
Signed-off-by: Julien Cristau <jcristau@debian.org>
Diffstat (limited to 'xorg-server/hw/xnest/Keyboard.c')
0 files changed, 0 insertions, 0 deletions