aboutsummaryrefslogtreecommitdiff
path: root/MERGE-REVIEW
diff options
context:
space:
mode:
authorCharles Kerr <charles.kerr@canonical.com>2014-06-10 13:58:14 -0500
committerCharles Kerr <charles.kerr@canonical.com>2014-06-10 13:58:14 -0500
commitf0e1d7daf7bf3b9ac7f1998ceec5c2c94a3ceab4 (patch)
tree96133d0e574903d19253f258ba92495cd683a355 /MERGE-REVIEW
parenta5e5f4ccf55c61be72daa28e4e5b581a6dd9571b (diff)
downloadayatana-indicator-datetime-f0e1d7daf7bf3b9ac7f1998ceec5c2c94a3ceab4.tar.gz
ayatana-indicator-datetime-f0e1d7daf7bf3b9ac7f1998ceec5c2c94a3ceab4.tar.bz2
ayatana-indicator-datetime-f0e1d7daf7bf3b9ac7f1998ceec5c2c94a3ceab4.zip
in MERGE-REVIEW, outline the steps needed to run hw alarm wakeup tests
Diffstat (limited to 'MERGE-REVIEW')
-rw-r--r--MERGE-REVIEW35
1 files changed, 30 insertions, 5 deletions
diff --git a/MERGE-REVIEW b/MERGE-REVIEW
index 5e40f45..1a5815c 100644
--- a/MERGE-REVIEW
+++ b/MERGE-REVIEW
@@ -6,14 +6,39 @@ and reviewers should ensure that they've done for a merge into the project.
* Ensure the project compiles and the test suite executes without error
* Ensure that non-obvious code has comments explaining it
- * If the change works on specific profiles, please include those in the merge description.
+ * If the change affects specific features, please reference the appropriate
+ tags in the merge description so reviewers can test appropriately:
+ [phone profile], [desktop profile], [alarms]
== Reviewer Responsibilities ==
* Did the Jenkins build compile? Pass? Run unit tests successfully?
* Are there appropriate tests to cover any new functionality?
- * If the description says this effects the phone profile:
- * Run tests indicator-datetime/unity8*
- * If the description says this effects the desktop profile:
- * Run tests indicator-datetime/unity7*
+ * Do the tag-specific tests pass?
+
+== Phone Profile Tests ==
+
+ * Run tests indicator-datetime/unity8*
+
+== Desktop Profile Tests ==
+
+ * Run tests indicator-datetime/unity7*
+
+== Alarm Tests ==
+
+ * Hardware wakeups for new alarms:
+ 1. Create and save an upcoming alarm in ubuntu-clock-app.
+ 2. Unplug the phone from any USB connection and put it to sleep.
+ 3. Confirm that the alarm sounds on time even if the phone is asleep.
+ (Note: if in doubt about sleep you can see in the syslog whether the
+ device actually suspended or whether the suspend was aborted)
+
+ * Hardware wakeups for edited alarms:
+ 1. Edit an alarm that's already passed. (see previous test)
+ 2. Unplug the phone from any USB connection and put it to sleep.
+ 3. Confirm that the alarm sounds on time even if the phone is asleep.
+ (Note: if in doubt about sleep you can see in the syslog whether the
+ device actually suspended or whether the suspend was aborted.)
+
+