diff options
| author | Ted Gould <ted@gould.cx> | 2014-01-31 14:21:24 -0600 |
|---|---|---|
| committer | Ted Gould <ted@gould.cx> | 2014-01-31 14:21:24 -0600 |
| commit | 7dbad5e7d78789ea9eba4cbdc72b6489b53043a3 (patch) | |
| tree | 181d26728d57e08458fdef8e68d26c90b2a0bd10 /MERGE-REVIEW | |
| parent | 02ae3d9f3df19e9db55a370d140c00b1be8d3fa4 (diff) | |
| download | ayatana-indicator-messages-7dbad5e7d78789ea9eba4cbdc72b6489b53043a3.tar.gz ayatana-indicator-messages-7dbad5e7d78789ea9eba4cbdc72b6489b53043a3.tar.bz2 ayatana-indicator-messages-7dbad5e7d78789ea9eba4cbdc72b6489b53043a3.zip | |
Adding merge review policy
Diffstat (limited to 'MERGE-REVIEW')
| -rw-r--r-- | MERGE-REVIEW | 19 |
1 files changed, 19 insertions, 0 deletions
diff --git a/MERGE-REVIEW b/MERGE-REVIEW new file mode 100644 index 0000000..3887066 --- /dev/null +++ b/MERGE-REVIEW @@ -0,0 +1,19 @@ + +This documents the expections that the project has on what both submitters +and reviewers should ensure that they've done for a merge into the project. + +== Submitter Responsibilities == + + * Ensure the project compiles and the test suite executes without error + * Ensure that non-obvious code has comments explaining it + * If the change works on specific profiles, please include those in the merge description. + +== Reviewer Responsibilities == + + * Did the Jenkins build compile? Pass? Run unit tests successfully? + * Are there appropriate tests to cover any new functionality? + * If the description says this effects the phone profile: + * Run tests indicator-messages/unity8* + * If the description says this effects the desktop profile: + * Run tests indicator-messages/unity7* + |