diff options
| author | Ted Gould <ted@gould.cx> | 2010-04-14 11:37:25 -0500 |
|---|---|---|
| committer | Ted Gould <ted@gould.cx> | 2010-04-14 11:37:25 -0500 |
| commit | 3dbca0954d9f02df4c9a45a2d4573000d5b4a622 (patch) | |
| tree | 02688309a4b022c2ed588c80a9e75052e674ded2 | |
| parent | 00a7938319d15cb6484b8e7dc897d854816772bf (diff) | |
| download | libdbusmenu-3dbca0954d9f02df4c9a45a2d4573000d5b4a622.tar.gz libdbusmenu-3dbca0954d9f02df4c9a45a2d4573000d5b4a622.tar.bz2 libdbusmenu-3dbca0954d9f02df4c9a45a2d4573000d5b4a622.zip | |
A couple of code review comments
| -rw-r--r-- | libdbusmenu-glib/client.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/libdbusmenu-glib/client.c b/libdbusmenu-glib/client.c index f5546a2..3ce0ccb 100644 --- a/libdbusmenu-glib/client.c +++ b/libdbusmenu-glib/client.c @@ -748,6 +748,7 @@ parse_layout_xml(DbusmenuClient * client, xmlNodePtr node, DbusmenuMenuitem * it if (parent != NULL) { dbusmenu_menuitem_child_delete(parent, item); } + /* XXX: Should this be an unref? Who's reffing this that it exists without a parent? */ g_object_unref(G_OBJECT(item)); item = NULL; } @@ -773,6 +774,7 @@ parse_layout_xml(DbusmenuClient * client, xmlNodePtr node, DbusmenuMenuitem * it } } else { /* Refresh the properties */ + /* XXX: We shouldn't need to get the properties everytime we reuse an entry */ gchar * properties[1] = {NULL}; /* This gets them all */ org_ayatana_dbusmenu_get_properties_async(proxy, id, (const gchar **)properties, menuitem_get_properties_replace_cb, item); } |