aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCharles Kerr <charles.kerr@canonical.com>2012-04-10 17:54:52 -0500
committerCharles Kerr <charles.kerr@canonical.com>2012-04-10 17:54:52 -0500
commit514253caa8b99331f11bf91b15fffe0fe44f5e0c (patch)
tree634090e2f6e8b6d94e2bc3cb37f733de39887d4c
parent2663918c2f2b66efae22aae19fa1ff3a73e81df4 (diff)
downloadlibdbusmenu-514253caa8b99331f11bf91b15fffe0fe44f5e0c.tar.gz
libdbusmenu-514253caa8b99331f11bf91b15fffe0fe44f5e0c.tar.bz2
libdbusmenu-514253caa8b99331f11bf91b15fffe0fe44f5e0c.zip
In menuitem_signals_remove(), disconnect the DBUSMENU_MENUITEM_SIGNAL_SHOW_TO_USER event that we connected to in menuitem_signals_create().
It looks like this non-disconnected signal goes all the way back to July 2010 <http://bazaar.launchpad.net/~dbusmenu-team/dbusmenu/trunk.0.6/revision/139#libdbusmenu-glib/server.c> so I'd like ted's eyes on this to confirm there's not some nuance that I'm missing...
-rw-r--r--libdbusmenu-glib/server.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/libdbusmenu-glib/server.c b/libdbusmenu-glib/server.c
index ebe0082..9e5ef0c 100644
--- a/libdbusmenu-glib/server.c
+++ b/libdbusmenu-glib/server.c
@@ -1288,6 +1288,7 @@ menuitem_signals_remove (DbusmenuMenuitem * mi, gpointer data)
g_signal_handlers_disconnect_by_func(G_OBJECT(mi), G_CALLBACK(menuitem_child_removed), data);
g_signal_handlers_disconnect_by_func(G_OBJECT(mi), G_CALLBACK(menuitem_child_moved), data);
g_signal_handlers_disconnect_by_func(G_OBJECT(mi), G_CALLBACK(menuitem_property_changed), data);
+ g_signal_handlers_disconnect_by_func(G_OBJECT(mi), G_CALLBACK(menuitem_shown), data);
return;
}