aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTed Gould <ted@gould.cx>2010-10-15 11:47:09 -0500
committerTed Gould <ted@gould.cx>2010-10-15 11:47:09 -0500
commitabfd276f1d5aa79ebc30d9dccbe4e4d58315c499 (patch)
tree3aa0cded377ffeff8145a173aad49b71e811ea6f
parent966d397a36971552609e24bb8071fdb69c4c279a (diff)
downloadlibdbusmenu-abfd276f1d5aa79ebc30d9dccbe4e4d58315c499.tar.gz
libdbusmenu-abfd276f1d5aa79ebc30d9dccbe4e4d58315c499.tar.bz2
libdbusmenu-abfd276f1d5aa79ebc30d9dccbe4e4d58315c499.zip
Converting GetProperties
-rw-r--r--libdbusmenu-glib/server.c28
1 files changed, 19 insertions, 9 deletions
diff --git a/libdbusmenu-glib/server.c b/libdbusmenu-glib/server.c
index e83015a..a2d34d5 100644
--- a/libdbusmenu-glib/server.c
+++ b/libdbusmenu-glib/server.c
@@ -39,7 +39,6 @@ License version 3 and version 2.1 along with this program. If not, see
#include "dbus-menu.xml.h"
/* DBus Prototypes */
-static gboolean _dbusmenu_server_get_properties (DbusmenuServer * server, gint id, gchar ** properties, GHashTable ** dict, GError ** error);
static gboolean _dbusmenu_server_event (DbusmenuServer * server, gint id, gchar * eventid, GValue * data, guint timestamp, GError ** error);
static gboolean _dbusmenu_server_about_to_show (DbusmenuServer * server, gint id, gboolean * need_update, GError ** error);
@@ -105,6 +104,7 @@ enum {
METHOD_GET_GROUP_PROPERTIES,
METHOD_GET_CHILDREN,
METHOD_GET_PROPERTY,
+ METHOD_GET_PROPERTIES,
/* Counter, do not remove! */
METHOD_COUNT
};
@@ -169,6 +169,9 @@ static void bus_get_children (DbusmenuServer * server,
static void bus_get_property (DbusmenuServer * server,
GVariant * params,
GDBusMethodInvocation * invocation);
+static void bus_get_properties (DbusmenuServer * server,
+ GVariant * params,
+ GDBusMethodInvocation * invocation);
/* Globals */
static GDBusNodeInfo * dbusmenu_node_info = NULL;
@@ -309,6 +312,9 @@ dbusmenu_server_class_init (DbusmenuServerClass *class)
dbusmenu_method_table[METHOD_GET_PROPERTY].interned_name = g_intern_static_string("GetProperty");
dbusmenu_method_table[METHOD_GET_PROPERTY].func = bus_get_property;
+ dbusmenu_method_table[METHOD_GET_PROPERTIES].interned_name = g_intern_static_string("GetProperties");
+ dbusmenu_method_table[METHOD_GET_PROPERTIES].func = bus_get_properties;
+
return;
}
@@ -779,26 +785,30 @@ bus_get_property (DbusmenuServer * server, GVariant * params, GDBusMethodInvocat
return;
}
-static gboolean
-_dbusmenu_server_get_properties (DbusmenuServer * server, gint id, gchar ** properties, GHashTable ** dict, GError ** error)
+/* Get some properties off of a single menuitem */
+static void
+bus_get_properties (DbusmenuServer * server, GVariant * params, GDBusMethodInvocation * invocation)
{
DbusmenuServerPrivate * priv = DBUSMENU_SERVER_GET_PRIVATE(server);
+
+ gint id = g_variant_get_int32(g_variant_get_child_value(params, 0));
+
DbusmenuMenuitem * mi = dbusmenu_menuitem_find_id(priv->root, id);
if (mi == NULL) {
- if (error != NULL) {
- g_set_error(error,
+ g_dbus_method_invocation_return_error(invocation,
error_quark(),
INVALID_MENUITEM_ID,
"The ID supplied %d does not refer to a menu item we have",
id);
- }
- return FALSE;
+ return;
}
- *dict = dbusmenu_menuitem_properties_copy(mi);
+ GVariant * dict = dbusmenu_menuitem_properties_variant(mi);
- return TRUE;
+ g_dbus_method_invocation_return_value(invocation, dict);
+
+ return;
}
/* Handles getting a bunch of properties from a variety of menu items