aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTed Gould <ted@gould.cx>2011-03-01 11:47:12 -0600
committerTed Gould <ted@gould.cx>2011-03-01 11:47:12 -0600
commitb2f6b6137f9a0bfe587d91b1437a6b3894ea1509 (patch)
treef74964efe711774c84cbf21410322d59a556fd22
parentb9aabb88761d30b5edd2e84d422698ed80aae349 (diff)
parente45f9a41dd7104152d462870d6ac8feb0f64c0b5 (diff)
downloadlibdbusmenu-b2f6b6137f9a0bfe587d91b1437a6b3894ea1509.tar.gz
libdbusmenu-b2f6b6137f9a0bfe587d91b1437a6b3894ea1509.tar.bz2
libdbusmenu-b2f6b6137f9a0bfe587d91b1437a6b3894ea1509.zip
Check for valid name before building up variant.
-rw-r--r--libdbusmenu-gtk/menuitem.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/libdbusmenu-gtk/menuitem.c b/libdbusmenu-gtk/menuitem.c
index 508b43f..370dbf2 100644
--- a/libdbusmenu-gtk/menuitem.c
+++ b/libdbusmenu-gtk/menuitem.c
@@ -177,6 +177,9 @@ dbusmenu_menuitem_property_set_shortcut (DbusmenuMenuitem * menuitem, guint key,
g_return_val_if_fail(DBUSMENU_IS_MENUITEM(menuitem), FALSE);
g_return_val_if_fail(gtk_accelerator_valid(key, modifier), FALSE);
+ const gchar * keyname = gdk_keyval_name(key);
+ g_return_val_if_fail(keyname != NULL, FALSE);
+
GVariantBuilder builder;
g_variant_builder_init(&builder, G_VARIANT_TYPE_ARRAY);
@@ -193,7 +196,6 @@ dbusmenu_menuitem_property_set_shortcut (DbusmenuMenuitem * menuitem, guint key,
g_variant_builder_add(&builder, "s", DBUSMENU_MENUITEM_SHORTCUT_SUPER);
}
- const gchar * keyname = gdk_keyval_name(key);
g_variant_builder_add(&builder, "s", keyname);
GVariant * inside = g_variant_builder_end(&builder);