diff options
| author | Charles Kerr <charles.kerr@canonical.com> | 2012-03-21 07:20:21 -0500 |
|---|---|---|
| committer | Charles Kerr <charles.kerr@canonical.com> | 2012-03-21 07:20:21 -0500 |
| commit | be73acbfefefb4581f82b19421fe5fc39941901e (patch) | |
| tree | dcba22a23c37261b16835d16d4fa1b940c87980f /docs | |
| parent | 06c5fccf713238d14d999a966b373fc832371b97 (diff) | |
| download | libdbusmenu-be73acbfefefb4581f82b19421fe5fc39941901e.tar.gz libdbusmenu-be73acbfefefb4581f82b19421fe5fc39941901e.tar.bz2 libdbusmenu-be73acbfefefb4581f82b19421fe5fc39941901e.zip | |
Don't listen for "changed" events from the screen's default GtkIconTheme. Fixes lp bug #953509
The crash in #953509 was being caused by the last two lines of theme_changed_cb() (a) leaving a dangling handler id in priv.theme_changed_sig, and (b) not remembering the handler id of its own signal connection. However after testing I don't see any reason to keep any of the theme handling code at all.
"But wait," you say. "How will our menu icons follow the theme changes?" It works in practice anyway because we always listen for property changes to our reference GtkImage, **and** we listen for property changes to its GtkImageMenuItem parent so that if the GtkImageMenuItem changes GtkImages we can stop listening to the old one and start listening to the new one.
Diffstat (limited to 'docs')
0 files changed, 0 insertions, 0 deletions