aboutsummaryrefslogtreecommitdiff
path: root/libdbusmenu-gtk
diff options
context:
space:
mode:
Diffstat (limited to 'libdbusmenu-gtk')
-rw-r--r--libdbusmenu-gtk/Makefile.am2
-rw-r--r--libdbusmenu-gtk/client.c34
-rw-r--r--libdbusmenu-gtk/menu.c46
3 files changed, 75 insertions, 7 deletions
diff --git a/libdbusmenu-gtk/Makefile.am b/libdbusmenu-gtk/Makefile.am
index 918d071..87a82a6 100644
--- a/libdbusmenu-gtk/Makefile.am
+++ b/libdbusmenu-gtk/Makefile.am
@@ -26,7 +26,7 @@ libdbusmenu_gtk_la_LDFLAGS = \
-export-symbols-regex "^[^_].*"
libdbusmenu_gtk_la_CFLAGS = \
- $(DBUSMENUGTK_CFLAGS) -I$(srcdir)/.. -Wall -Werror
+ $(DBUSMENUGTK_CFLAGS) -I$(srcdir)/.. -Wall -Werror -DG_DISABLE_DEPRECATED -DG_LOG_DOMAIN="\"LIBDBUSMENU-GTK\""
libdbusmenu_gtk_la_LIBADD = \
../libdbusmenu-glib/libdbusmenu-glib.la \
diff --git a/libdbusmenu-gtk/client.c b/libdbusmenu-gtk/client.c
index 901d739..8489424 100644
--- a/libdbusmenu-gtk/client.c
+++ b/libdbusmenu-gtk/client.c
@@ -159,7 +159,9 @@ menu_prop_change_cb (DbusmenuMenuitem * mi, gchar * prop, gchar * value, GtkMenu
static void
destoryed_dbusmenuitem_cb (gpointer udata, GObject * dbusmenuitem)
{
- /* g_debug("DbusmenuMenuitem was destroyed"); */
+ #ifdef MASSIVEDEBUGGING
+ g_debug("DbusmenuMenuitem was destroyed");
+ #endif
gtk_widget_destroy(GTK_WIDGET(udata));
return;
}
@@ -176,6 +178,15 @@ new_menuitem (DbusmenuClient * client, DbusmenuMenuitem * mi, gpointer userdata)
return;
}
+#ifdef MASSIVEDEBUGGING
+static void
+destroy_gmi (GtkMenuItem * gmi, DbusmenuMenuitem * mi)
+{
+ g_debug("Destorying GTK Menuitem for %d", dbusmenu_menuitem_get_id(mi));
+ return;
+}
+#endif
+
/**
dbusmenu_gtkclient_newitem_base:
@client: The client handling everything on this connection
@@ -195,8 +206,16 @@ new_menuitem (DbusmenuClient * client, DbusmenuMenuitem * mi, gpointer userdata)
void
dbusmenu_gtkclient_newitem_base (DbusmenuGtkClient * client, DbusmenuMenuitem * item, GtkMenuItem * gmi, DbusmenuMenuitem * parent)
{
+ #ifdef MASSIVEDEBUGGING
+ g_debug("GTK Client new item base for %d", dbusmenu_menuitem_get_id(item));
+ #endif
+
/* Attach these two */
g_object_set_data(G_OBJECT(item), data_menuitem, gmi);
+ g_object_ref(G_OBJECT(gmi));
+ #ifdef MASSIVEDEBUGGING
+ g_signal_connect(G_OBJECT(gmi), "destroy", G_CALLBACK(destroy_gmi), item);
+ #endif
/* DbusmenuMenuitem signals */
g_signal_connect(G_OBJECT(item), DBUSMENU_MENUITEM_SIGNAL_PROPERTY_CHANGED, G_CALLBACK(menu_prop_change_cb), gmi);
@@ -222,6 +241,10 @@ dbusmenu_gtkclient_newitem_base (DbusmenuGtkClient * client, DbusmenuMenuitem *
static void
new_child (DbusmenuMenuitem * mi, DbusmenuMenuitem * child, guint position, DbusmenuGtkClient * gtkclient)
{
+ #ifdef MASSIVEDEBUGGING
+ g_debug("GTK Client new child for %d on %d at %d", dbusmenu_menuitem_get_id(mi), dbusmenu_menuitem_get_id(child), position);
+ #endif
+
if (dbusmenu_menuitem_get_root(mi)) { return; }
gpointer ann_menu = g_object_get_data(G_OBJECT(mi), data_menu);
@@ -316,14 +339,13 @@ dbusmenu_gtkclient_menuitem_get (DbusmenuGtkClient * client, DbusmenuMenuitem *
g_return_val_if_fail(DBUSMENU_IS_GTKCLIENT(client), NULL);
g_return_val_if_fail(DBUSMENU_IS_MENUITEM(item), NULL);
- GtkMenuItem * mi = GTK_MENU_ITEM(g_object_get_data(G_OBJECT(item), data_menuitem));
- if (mi == NULL) {
- // new_menuitem(DBUSMENU_CLIENT(client), item, NULL);
+ gpointer data = g_object_get_data(G_OBJECT(item), data_menuitem);
+ if (data == NULL) {
g_warning("GTK not updated");
- mi = GTK_MENU_ITEM(g_object_get_data(G_OBJECT(item), data_menuitem));
+ return NULL;
}
- return mi;
+ return GTK_MENU_ITEM(data);
}
/* The base type handler that builds a plain ol'
diff --git a/libdbusmenu-gtk/menu.c b/libdbusmenu-gtk/menu.c
index 5bcf0a1..2dd7a6e 100644
--- a/libdbusmenu-gtk/menu.c
+++ b/libdbusmenu-gtk/menu.c
@@ -185,6 +185,28 @@ get_property (GObject * obj, guint id, GValue * value, GParamSpec * pspec)
/* Internal Functions */
+#ifdef MASSIVEDEBUGGING
+typedef struct {
+ GtkMenuItem * mi;
+ gint finalpos;
+ gboolean found;
+} menu_pos_t;
+
+static void
+find_pos (GtkWidget * widget, gpointer data)
+{
+ menu_pos_t * menu_pos = (menu_pos_t *)data;
+ if (menu_pos->found) return;
+ if ((gpointer)(menu_pos->mi) == (gpointer)widget) {
+ menu_pos->found = TRUE;
+ } else {
+ menu_pos->finalpos++;
+ }
+ return;
+}
+#endif
+
+
/* Called when a new child of the root item is
added. Sets up a signal for when it's actually
realized. */
@@ -192,7 +214,24 @@ static void
root_child_added (DbusmenuMenuitem * root, DbusmenuMenuitem * child, guint position, DbusmenuGtkMenu * menu)
{
g_debug("Root new child");
+ DbusmenuGtkMenuPrivate * priv = DBUSMENU_GTKMENU_GET_PRIVATE(menu);
+
g_signal_connect(G_OBJECT(child), DBUSMENU_MENUITEM_SIGNAL_REALIZED, G_CALLBACK(child_realized), menu);
+
+ GtkMenuItem * mi = dbusmenu_gtkclient_menuitem_get(priv->client, child);
+ if (mi != NULL) {
+ GtkWidget * item = GTK_WIDGET(mi);
+ gtk_menu_insert(GTK_MENU(menu), item, position);
+ #ifdef MASSIVEDEBUGGING
+ menu_pos_t menu_pos;
+ menu_pos.mi = mi;
+ menu_pos.finalpos = 0;
+ menu_pos.found = FALSE;
+
+ gtk_container_foreach(GTK_CONTAINER(menu), find_pos, &menu_pos);
+ g_debug("Menu position requested was %d but got %d", position, menu_pos.finalpos);
+ #endif
+ }
return;
}
@@ -212,6 +251,12 @@ static void
root_child_delete (DbusmenuMenuitem * root, DbusmenuMenuitem * child, DbusmenuGtkMenu * menu)
{
g_debug("Root child deleted");
+ DbusmenuGtkMenuPrivate * priv = DBUSMENU_GTKMENU_GET_PRIVATE(menu);
+ GtkWidget * item = GTK_WIDGET(dbusmenu_gtkclient_menuitem_get(priv->client, child));
+ if (item != NULL) {
+ gtk_container_remove(GTK_CONTAINER(menu), item);
+ }
+
if (g_list_length(dbusmenu_menuitem_get_children(root)) == 0) {
gtk_widget_hide(GTK_WIDGET(menu));
}
@@ -223,6 +268,7 @@ root_child_delete (DbusmenuMenuitem * root, DbusmenuMenuitem * child, DbusmenuGt
static void
child_realized (DbusmenuMenuitem * child, gpointer userdata)
{
+ g_debug("Root child realized");
g_return_if_fail(DBUSMENU_IS_GTKMENU(userdata));
DbusmenuGtkMenu * menu = DBUSMENU_GTKMENU(userdata);