aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorUlrich Sibiller <uli42@gmx.de>2016-10-20 00:15:20 +0200
committerUlrich Sibiller <u.sibiller@science-computing.de>2016-10-20 10:16:35 +0200
commit50eb5e4a9bf812895a7d5c4e6ae0775c6910931f (patch)
treef0f84ebfb28ec44254def01211eeca94c76aeed4
parent151e0b16da708f54a03cf50e104f2ac43ec16a5b (diff)
downloadnx-libs-50eb5e4a9bf812895a7d5c4e6ae0775c6910931f.tar.gz
nx-libs-50eb5e4a9bf812895a7d5c4e6ae0775c6910931f.tar.bz2
nx-libs-50eb5e4a9bf812895a7d5c4e6ae0775c6910931f.zip
sendexev.c: Fix return of unitialized variable
Well, kinda fix. Upstream handles that differently here, we need a thorough check! Add another FIXME comment because of this.
-rw-r--r--nx-X11/programs/Xserver/Xi/sendexev.c10
1 files changed, 7 insertions, 3 deletions
diff --git a/nx-X11/programs/Xserver/Xi/sendexev.c b/nx-X11/programs/Xserver/Xi/sendexev.c
index 28286d97f..a851c5120 100644
--- a/nx-X11/programs/Xserver/Xi/sendexev.c
+++ b/nx-X11/programs/Xserver/Xi/sendexev.c
@@ -149,10 +149,14 @@ ProcXSendExtensionEvent (client)
return Success;
}
- // FIXME: ret is not initialized and should not be returned...
-
+ /*
+ the previous code here returned the unitialized variable ret,
+ so using Success we have defined returncode at least. FIXME:
+ Upstream works different here, we must check this!
+ */
if (stuff->num_events == 0)
- return ret;
+ /* return ret; */
+ return Success;
/* The client's event type must be one defined by an extension. */