aboutsummaryrefslogtreecommitdiff
path: root/nxcomp
Commit message (Collapse)AuthorAgeFilesLines
* Update Copyright yearsUlrich Sibiller2023-04-28230-924/+924
| | | | Addresses ArcticaProject/nx-libs#985
* nxcomp: delete trailing whitespaceUlrich Sibiller2023-04-27108-463/+463
|
* Loop.cpp: spelling fixUlrich Sibiller2023-04-271-1/+1
|
* document additional options only nxagent knows aboutUlrich Sibiller2021-06-081-18/+23
|
* nxcomp/src/BlockCacheSet.cpp: Amend comment behind if-clause closure.Mike Gabriel2021-06-081-1/+1
|
* nxcomp: Support Cygwin64.Vadim Troshchinskiy2021-06-0810-25/+25
| | | | 64 bit Cygwin defines __CYGWIN__ instead of __CYGWIN32__
* nxcomp/Children.cpp: print a message if the dialog could not be displayedUlrich Sibiller2021-06-081-0/+9
|
* nxcomp/Children.cpp: reformat codeUlrich Sibiller2021-06-081-11/+0
| | | | drop some superflous empty lines to make code more compact.
* nxcomp/Children.cpp: also try searching nxdialog, not only nxclientUlrich Sibiller2021-06-081-2/+20
|
* nxcomp/Children.cpp: add macro checks around some log/stderr printsUlrich Sibiller2021-06-081-2/+6
| | | | This helps no flooding the output with (double) messages.
* nxcomp/Children.cpp: display dialog text in outputUlrich Sibiller2021-06-081-1/+9
| | | | | | | | This ensures the dialog text is visible in the log which is useful when the dialog display tool (nxclient, nxdialog, ...) fails or cannot be found. Fixes ArcticaProject/nx-libs#915
* fix formatting and spelling in various filesUlrich Sibiller2021-01-153-3/+3
|
* Log.h: fix some shadow warningsUlrich Sibiller2020-11-031-7/+7
| | | | | | | | | | | "warning: declaration of '<something>' shadows a member of 'this' This shows up in gcc 4.8.5 and has been fixed in gcc 5.0, see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=57709 Change the variable names anyway to be on the safe side. Fixes ArcticaProject/nx-libs#958
* Channel.h: rename variable to prevent shadowingUlrich Sibiller2020-11-031-4/+4
| | | | | | | | | | | | | | | | | | | | | | | In file included from Proxy.h:39:0, from ServerProxy.h:32, from ServerProxy.cpp:36: Channel.h: In member function 'int Channel::handleEncodeIdentity(EncodeBuffer&, ChannelCache*, MessageStore*, const unsigned char*, unsigned int, int)': Channel.h:369:3: warning: declaration of 'bigEndian' shadows a member of 'this' [-Wshadow] { ^ Channel.h: In member function 'int Channel::handleDecodeIdentity(DecodeBuffer&, ChannelCache*, MessageStore*, unsigned char*&, unsigned int&, int, WriteBuffer*)': Channel.h:378:3: warning: declaration of 'bigEndian' shadows a member of 'this' [-Wshadow] { ^ RHEL7's g++ 4.8.5 reports this while Debian's g++ 10.2.0-15 does not. This is described in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=57709 and fixed in gcc 5.0. Rename the variables anyway to be on the safe side. Fixes ArcticaProject/nx-libs#956
* Enable slave socket in server modeVadim Troshchinskiy2020-05-301-1/+2
|
* NX.h: Add missing NX_CHANNEL_SLAVE type to descriptionUlrich Sibiller2020-05-071-0/+3
|
* Use nxdialog as nxclient replacementUlrich Sibiller2020-05-071-5/+15
| | | | | | | if neither NX_CLIENT ist provided nor /usr/NX/bin/nxclient is existing try /usr/bin/nxdialog. Currently the path is hardcoded.
* Add support for custom version stringUlrich Sibiller2020-01-052-4/+16
| | | | | | | | | | | Make nxproxy and nxagent print an arbitrary version number by running make NX_VERSION_CUSTOM="myvers". nxagent and nxproxy will then show this in addition to the original version number: NXPROXY - Version myvers (3.5.99.22) NXAGENT - Version myvers (3.5.99.22) Fixes ArcticaProject/nx-libs#606
* nxagent: simplify nxagentWaitEvents()Ulrich Sibiller2019-08-161-0/+4
| | | | | no more need to pass down a struct, we now only pass the milliseconds and let the function do the rest.
* nxcomp/src/Makefile.am: Correct usage of PTHREAD_CFLAGS and PTHREAD_LIBS. ↵Mike Gabriel2019-04-071-2/+2
| | | | PTHREAD_CFLAGS is also supposed to be used when linking. See comments in m4/ax_pthread.m4.
* nxcomp/src/Makefile.am: PTHREAD_LDFLAGS does not exist, replace with ↵Mihai Moldovan2019-04-041-1/+1
| | | | PTHREAD_LIBS.
* GenericReply.h: remove unused variableUlrich Sibiller2019-03-011-1/+0
|
* nxcomp: fix unused variablesUlrich Sibiller2019-03-011-4/+4
|
* nxcomp: fix unused variableUlrich Sibiller2019-03-011-1/+0
|
* Revert "Fix parsing ports set to unix sockets"Mike Gabriel2019-02-201-5/+1
| | | | | | This reverts commit 889de46f759913742478d2cfe20f1f4a6c2effdc. Fixes ArcticaProject/nx-libs#775.
* Regression fix for bfc05af7. Properly end lines in help/usage text.Mike Gabriel2019-02-201-1/+1
| | | | Fixes ArcticaProject/nx-libs#777.
* nxproxy: list known session types in help outputUlrich Sibiller2019-02-181-2/+5
| | | | | | | | The old unix-* session types are deprecated and will always lead to a warning message "Unrecognized session type". Internally there are only three session types: agent, proxy and shadow, all the others are mapped to one of those three.
* Fix parsing ports set to unix socketsVadim2019-01-221-1/+5
|
* Make getUnixPath() return the right value when called without an argument.Vadim2019-01-211-3/+3
| | | | This fixes the verification in validateSpec()
* Fix some memory leaks.Mario Trangoni2018-07-031-0/+1
|
* nxcomp: fix spelling errors as reported by codespellUlrich Sibiller2018-05-2412-18/+18
|
* nxcomp{,shad}/configure.ac: replace versionating non-portable sed construct ↵Mihai Moldovan2018-03-071-1/+1
| | | | with hopefully more portable awk construct.
* nxcomp{,shad}/configure.ac: pass more portable -E option to sed instead of -r.Mihai Moldovan2018-03-021-1/+1
|
* Fix clang error: comparison of array authCookie not equal to a null pointer ↵Mario Trangoni2018-03-011-1/+1
| | | | is always true
* nxagent: Also provide auto DPI feature via nx/nx option 'autodpi', taking ↵Mike Gabriel2018-02-272-1/+3
| | | | only effect on session startups.
* nxcomp/src/Loop.cpp: Harmonize log output. Uniformly, embrace port values by ↵Mike Gabriel2018-02-271-6/+6
| | | | | | single quotes. Fixes ArcticaProject/nx-libs#617.
* nxcomp/src/Loop.cpp: Make know the agent option 'keyconv' to nxcomp and ↵Mike Gabriel2018-02-271-1/+2
| | | | | | tolerate it as a valid option. Fixes ArcticaProject/nx-libs#630.
* nxagent: Add support for optionally enabling/disabling the magic pixel feature.Mike Gabriel2018-02-262-1/+3
| | | | Fixes ArcticaProject/nx-libs#657.
* nxcomp{,shad}/configure.ac: trailing whitespace removal only.Mihai Moldovan2018-02-251-1/+1
|
* nxcomp/src/Loop.cpp: Typo fix in error msg.Mike Gabriel2018-01-201-1/+1
|
* nxcomp/src/Timestamp.{cpp,h}: use ::ctime_s or ::ctime_r instead of plain ↵Mihai Moldovan2018-01-092-22/+49
| | | | | | ctime, on-stack buffers and return std::string objects. Fixes: ArcticaProject/nx-libs#616
* nxcomp/configure.ac: add check for ::ctime_s.Mihai Moldovan2018-01-081-0/+17
|
* EncodeBuffer.cpp: add another VALGRIND guardUlrich Sibiller2017-12-291-1/+9
| | | | Fixes ArcticaProject/nx-libs#572
* nxcomp: drop strncpy in favour of snprintfUlrich Sibiller2017-12-293-44/+33
| | | | with very few exceptions which require careful thinking ;-)
* Loop.cpp: fix memleak happening with unknown tcp hostUlrich Sibiller2017-12-291-0/+1
| | | | | | | | | | | | | | | ==28424== 6 bytes in 1 blocks are definitely lost in loss record 1 of 7 ==28424== at 0x4C2DB8F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==28424== by 0x541D4D9: strndup (strndup.c:43) ==28424== by 0x4E8AD4B: ChannelEndPoint::getTCPHostAndPort(char**, long*) const (ChannelEndPoint.cpp:311) ==28424== by 0x4EBE9CC: ConnectToRemote(ChannelEndPoint&) (Loop.cpp:6656) ==28424== by 0x4EB0A4C: SetupProxyConnection() (Loop.cpp:3205) ==28424== by 0x4EDC81A: handleNegotiationInLoop(int&, fd_set&, fd_set&, timeval&) (Loop.cpp:14308) ==28424== by 0x4EAE40F: NXTransPrepare (Loop.cpp:2576) ==28424== by 0x4EAA801: NXTransContinue (Loop.cpp:1610) ==28424== by 0x4EB50C9: WaitCleanup() (Loop.cpp:4436) ==28424== by 0x4EA9507: NXTransProxy (Loop.cpp:1235) ==28424== by 0x400B2A: main (Main.c:111)
* ChannelEndPoint.cpp: fix possible memleak in getUnixPath()Ulrich Sibiller2017-12-293-4/+7
|
* ChannelEndPoint.cpp: remove unneccessary codeUlrich Sibiller2017-12-291-2/+0
| | | | SAFE_FREE has set defaultUnixPath_ to NULL already
* ChannelEndPoint.cpp: fix another memleakUlrich Sibiller2017-12-293-3/+7
| | | | | | | | | | | | | | | ==7689== 50 bytes in 5 blocks are definitely lost in loss record 1 of 2 ==7689== at 0x4C2DB8F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==7689== by 0x54074D9: strndup (strndup.c:43) ==7689== by 0x4E7D803: ChannelEndPoint::getTCPHostAndPort(char**, long*) const (ChannelEndPoint.cpp:309) ==7689== by 0x4EC9D93: ConnectToRemote(ChannelEndPoint&) [clone .constprop.144] (Loop.cpp:6660) ==7689== by 0x4ECB94E: SetupProxyConnection() (Loop.cpp:3204) ==7689== by 0x4ECE824: handleNegotiationInLoop(int&, fd_set&, fd_set&, timeval&) [clone .isra.129] (Loop.cpp:14312) ==7689== by 0x4ED0F8A: NXTransPrepare (Loop.cpp:2575) ==7689== by 0x4ED1C35: NXTransContinue (Loop.cpp:1609) ==7689== by 0x4ED1D7B: WaitCleanup() (Loop.cpp:4440) ==7689== by 0x4ED2343: NXTransProxy (Loop.cpp:1234) ==7689== by 0x400B2A: main (Main.c:111)
* EncodeBuffer.cpp: add VALGRIND guardUlrich Sibiller2017-12-291-0/+7
| | | | | | | Same as in WriteBuffer.cpp Valgrind will complain about uninitialized data, but we are only writing to the memory here.
* nxcomp: implement correct length handling for unix socket structsUlrich Sibiller2017-12-292-28/+57
| | | | (partially) fixes ArcticaProject/nx-libs#612