Fix use of un-initialized memory

Since m_valid was not initialized calling setValid ends up in an uninitialized memory use in the if comparison. The other thing setValid does is emitting a signal, but this is the constructor, so you don't need the signal either, so basically just assign the variable directly
.

Approved by PS Jenkins bot, Lars Uebernickel.

1 files changed, 2 insertions, 3 deletions

diff --git a/libqmenumodel/src/qstateaction.cpp b/libqmenumodel/src/qstateaction.cpp
index 40d70a5..983064a 100644
--- a/libqmenumodel/src/qstateaction.cpp
+++ b/libqmenumodel/src/qstateaction.cpp
@@ -62,9 +62,8 @@ QStateAction::QStateAction(QDBusActionGroup *group, const QString &name)
 
 
 
-    bool isValid = m_group->hasAction(name);
-    setValid(isValid);
-    if (isValid) {
+    m_valid = m_group->hasAction(name);
+    if (m_valid) {
         setState(m_group->actionState(name));
     }
 }