aboutsummaryrefslogtreecommitdiff
path: root/pthreads/private.c
diff options
context:
space:
mode:
authorOlivier Fourdan <ofourdan@redhat.com>2015-01-16 20:08:59 +0100
committerMike DePaulo <mikedep333@gmail.com>2015-02-19 20:03:22 -0500
commit6f11c4ac377676d44324888c834ab6a17d9fe1dd (patch)
treedb669b68988606370efac75d3b776deec84885dd /pthreads/private.c
parent50ca778029d5847f8dec48594590d35015ed31d4 (diff)
downloadvcxsrv-6f11c4ac377676d44324888c834ab6a17d9fe1dd.tar.gz
vcxsrv-6f11c4ac377676d44324888c834ab6a17d9fe1dd.tar.bz2
vcxsrv-6f11c4ac377676d44324888c834ab6a17d9fe1dd.zip
xkb: Don't swap XkbSetGeometry data in the input buffer
The XkbSetGeometry request embeds data which needs to be swapped when the server and the client have different endianess. _XkbSetGeometry() invokes functions that swap these data directly in the input buffer. However, ProcXkbSetGeometry() may call _XkbSetGeometry() more than once (if there is more than one keyboard), thus causing on swapped clients the same data to be swapped twice in memory, further causing a server crash because the strings lengths on the second time are way off bounds. To allow _XkbSetGeometry() to run reliably more than once with swapped clients, do not swap the data in the buffer, use variables instead. Signed-off-by: Olivier Fourdan <ofourdan@redhat.com> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> (cherry picked from commit 81c90dc8f0aae3b65730409b1b615b5fa7280ebd) (cherry picked from commit 29be310c303914090298ddda93a5bd5d00a94945) Signed-off-by: Julien Cristau <jcristau@debian.org>
Diffstat (limited to 'pthreads/private.c')
0 files changed, 0 insertions, 0 deletions